-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stellar tx new payment
field of amount
is orders of magnitude off. Update the helper text
#1693
Comments
This was copy/pasted from the docs:
Would you prefer more detail? e.g. |
The doc for the amount option should be improved and show what a value should look like. In regards to the issue of whether the option should be a decimal or in stroops: There's a UX argument for yes, it should be decimal But there's also a UX argument for consistency within the CLI, and other commands in the CLI already accept the integer form because in transactions and on the network amounts are always represented as integers. This is because the network actually only knows stroops, and any concept or conventions of decimal places is something added off chain. e.g.:
So I think we should opt for the latter, consistency within the CLI, and make the documentation much clearer. |
Please also add to upstream docs because it was copy and pasted from there. |
This issue is stale because it has been assigned for 30 days with no activity. It will be closed in 30 days unless the stale label is removed, and the assignee is removed or updated. |
This issue is stale because it has been assigned for 30 days with no activity. It will be closed in 30 days unless the stale label is removed, and the assignee is removed or updated. |
We should use stroops and update the details |
Stellar tx new payment
field of amount
is orders of magnitude off.Stellar tx new payment
field of amount
is orders of magnitude off. Update the helper text
stellar tx new payment
says:This seems incorrect. The amount is actually defaulting to stroop and the amount is thus orders of magnitude different.
The text was updated successfully, but these errors were encountered: