From 852b78b2b1a802d8cb0fe429c9f2552352715cec Mon Sep 17 00:00:00 2001
From: Alon Lukatch <alon.l@starkware.co>
Date: Mon, 2 Dec 2024 16:00:09 +0200
Subject: [PATCH] add --fatal_warnings flag to error on warnings

---
 .github/workflows/starknet_p2p_specs_ci.yml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/starknet_p2p_specs_ci.yml b/.github/workflows/starknet_p2p_specs_ci.yml
index 342578a..951c01b 100644
--- a/.github/workflows/starknet_p2p_specs_ci.yml
+++ b/.github/workflows/starknet_p2p_specs_ci.yml
@@ -43,21 +43,21 @@ jobs:
         run: |
           for file in ${{ steps.find-protos.outputs.proto_files }}; do
             echo "Compiling $file"
-            protoc --rust_out=experimental-codegen=enabled,kernel=upb:$(mktemp -d) $file
+            protoc --fatal_warnings --rust_out=experimental-codegen=enabled,kernel=upb:$(mktemp -d) $file
           done
 
       - name: Validate Python compatibility
         run: |
           for file in ${{ steps.find-protos.outputs.proto_files }}; do
             echo "Compiling $file"
-            protoc --python_out=$(mktemp -d) $file
+            protoc --fatal_warnings --python_out=$(mktemp -d) $file
           done
 
       - name: Validate C++ compatibility
         run: |
           for file in ${{ steps.find-protos.outputs.proto_files }}; do
             echo "Compiling $file"
-            protoc --cpp_out=$(mktemp -d) $file
+            protoc --fatal_warnings --cpp_out=$(mktemp -d) $file
           done
 
       - name: Validate GO compatibility
@@ -66,7 +66,7 @@ jobs:
           export PATH=$PATH:$(go env GOPATH)/bin
           for file in ${{ steps.find-protos.outputs.proto_files }}; do
             echo "Compiling $file"
-            protoc --go_out=$(mktemp -d) --go_opt=paths=source_relative $file
+            protoc --fatal_warnings --go_out=$(mktemp -d) --go_opt=paths=source_relative $file
           done
 
       - name: Success Message