MantaOSC - version of Manta reported?

[sensestage]

I have a first edition Manta here to work with, and it would be nice to know from the software that I am working with a first edition.
Is it reported by the hardware?

[spiricom]

the software reports the serial number: v1 is less than 70, v2 numbers
start at 70

On Friday, May 22, 2015, sensestage notifications@github.com wrote:

I have a first edition Manta here to work with, and it would be nice to
know from the software that I am working with a first edition.
Is it reported by the hardware?

—
Reply to this email directly or view it on GitHub
#38.

[sensestage]

Are you sure?

At the moment I find this in the source code of MantaUSB.h:

int MantaUSB::GetSerialNumber(void)
{
   /* TODO: get serial number */
   return SerialNumber;
}

I'm happy to help out writing the OSC interface to get the information, just looking for where to add it.

[spiricom]

ah! not yet implemented in libmanta. the manta does report it upon
connection. Spencer, any chance of adding this in?

On Saturday, May 23, 2015, sensestage notifications@github.com wrote:

Are you sure?

At the moment I find this in the source code of MantaUSB.h:

int MantaUSB::GetSerialNumber(void)
{
/* TODO: get serial number */
return SerialNumber;
}

I'm happy to help out writing the OSC interface to get the information,
just looking for where to add it.

—
Reply to this email directly or view it on GitHub
#38 (comment).

[ssfrr]

When the connect method is called it sets the SerialNumber member variable, so you should be able to access that. It's protected so subclasses (including MantaOSC) should be able to access them. I guess the GetSerialNumber method should just be removed, or could return this.SerialNumber. I'm away from my computer for the next 24 hrs or so, but I can accept a PR.

[ssfrr]

whoops, looking at this again it looks like GetSerialNumber already returns the serial number, and that TODO comment is outdated. Have you found that method not to work?

I also just added a GetHardwareVersion method that just checks the serial number and returns 1 or 2. It's available in the latest master.

-s