Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add annotation with comma separated value #1095

Open
rob-64 opened this issue Apr 23, 2024 · 0 comments
Open

How to add annotation with comma separated value #1095

rob-64 opened this issue Apr 23, 2024 · 0 comments
Labels
status/need-triage Team needs to triage and take a first look

Comments

@rob-64
Copy link

rob-64 commented Apr 23, 2024

Trying to use Stakater Reloader (https://github.com/stakater/Reloader/tree/master), with a value to watch configmaps as follows:

annotations:
configmap.reloader.stakater.com/reload: "foo-configmap,bar-configmap,baz-configmap"

however, since I have to use SCDF to get the values to k8s, i have it in this format:

"configmap.reloader.stakater.com/reload:foo-configmap,bar-configmap,baz-configmap"

which gets past the code of PropertyParserUtils.getStringPairsToMap:

/**
* Positive look ahead that into a non capturing group that will skip all commas in quotes.
* Even number quotes will be ignored by the non capturing group.
/
String[] pairs = stringPairs.split(",(?=(?:[^\"]
"[^\"]")[^\"]*$)", -1);

BUT, it then fails skipper ReleaseService.install when passed to ManifestUtils.createManifest:99

image

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/need-triage Team needs to triage and take a first look
Projects
None yet
Development

No branches or pull requests

1 participant