Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static list in RemoteFunctions depends on import #6

Open
bontric opened this issue Feb 8, 2016 · 2 comments
Open

Static list in RemoteFunctions depends on import #6

bontric opened this issue Feb 8, 2016 · 2 comments
Labels

Comments

@bontric
Copy link
Collaborator

bontric commented Feb 8, 2016

# this
import Splonebox.Api.RemoteFunction
# references a dirfferent list (RemoteFunction.remote_functions) than

#this
import Api.RemoteFunction
@bontric bontric added the bug label Feb 8, 2016
@mkind
Copy link
Member

mkind commented Feb 9, 2016

As discussed, this is ~low prio for now.

@bontric bontric added the low label Feb 9, 2016
@bontric
Copy link
Collaborator Author

bontric commented Mar 11, 2016

This should not be a problem anymore. If the library is installed using setup.py and used correctly the imports are automated (05a1ebe).

It will be important though to keep using absolute imports within the project to avoid any related problems.

Another option is to put the remote_functions list within the init.py in splonecli/api . I'm not sure though if this is considered good practice.

@bontric bontric removed the bug label Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants