Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink SpinAppExecutor deployment config options #269

Open
calebschoepp opened this issue Jul 9, 2024 · 3 comments
Open

Rethink SpinAppExecutor deployment config options #269

calebschoepp opened this issue Jul 9, 2024 · 3 comments
Assignees
Labels
api-next Issues that require a new API version (changing existing fields, removing fields) enhancement New feature or request needs discussion

Comments

@calebschoepp
Copy link
Contributor

The createDeployment field is redundant. We can determine whether the deployment should be created based on whether deploymentConfig is defined or not.

@endocrimes
Copy link
Contributor

lazy q: do we have any required deploymentConfig fields today? - I thought everything had defaults

@calebschoepp
Copy link
Contributor Author

Looks like there is a required field

type ExecutorDeploymentConfig struct {
	// RuntimeClassName is the runtime class name that should be used by pods created
	// as part of a deployment.
	RuntimeClassName string `json:"runtimeClassName"`
}

@endocrimes endocrimes changed the title Remove createDeployment from SpinAppExecutor.spec Rethink SpinAppExecutor deployment config options Jul 13, 2024
@endocrimes endocrimes added the api-next Issues that require a new API version (changing existing fields, removing fields) label Jul 19, 2024
@endocrimes
Copy link
Contributor

We talked about this offline and settled on redesigning the fields over blanket removing things, tagging with api-next and self-assigning for design

@endocrimes endocrimes self-assigned this Jul 19, 2024
@endocrimes endocrimes added enhancement New feature or request needs discussion labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-next Issues that require a new API version (changing existing fields, removing fields) enhancement New feature or request needs discussion
Projects
None yet
Development

No branches or pull requests

2 participants