Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain errors don't show up in UI #4

Open
dbrgn opened this issue Dec 31, 2024 · 3 comments
Open

Certain errors don't show up in UI #4

dbrgn opened this issue Dec 31, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dbrgn
Copy link

dbrgn commented Dec 31, 2024

When anything goes wrong, this should be indicated in the UI.

For example, for this input:

{
    "space": "Test Makerspace",
    "api_compatibility": [18]
}

This error is returned:

screenshot-20241231-131156

...but nothing is shown in the UI.

Somewhat related to SpaceApi/validator#64

@dbrgn dbrgn added bug Something isn't working good first issue Good for newcomers labels Dec 31, 2024
@Sanjai451
Copy link

I'm interested in contributing to this project.
Could you explain the ways to reproduce the bug?
Can I get assigned?

@dbrgn
Copy link
Author

dbrgn commented Dec 31, 2024

@Sanjai451 sure, are you familiar with SpaceAPI (https://spaceapi.io/) already?

To reproduce, enter the code in the issue description here: https://validator.spaceapi.io/ui/ (choose "Validate Direct Input" in the header). The HTTP request returns an error (HTTP 400), which should be handled.

If the content is valid JSON, parse the text element and show it in the UI. Otherwise, show a generic error in the UI.

@Sanjai451
Copy link

Sanjai451 commented Dec 31, 2024

while starting the application using

npm start

image

but the url is not opening

image

can I get help with this localizing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants