Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intersections #5

Open
steinbro opened this issue Jan 10, 2024 · 1 comment
Open

Intersections #5

steinbro opened this issue Jan 10, 2024 · 1 comment
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@steinbro
Copy link
Member

The original Soundscape app announced upcoming intersections, reading out the streets that meet.

This will require knowing what road the user is currently on (see #4).

Getting the street names will require the ability to look up cached features by OSM ID, since each intersection feature is just a list of IDs..

@steinbro steinbro added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 10, 2024
steinbro added a commit that referenced this issue Jan 14, 2024
@steinbro
Copy link
Member Author

steinbro commented Jan 14, 2024

I added a basic implementation of this, but it could use many refinements:

  1. Roads should be announced spatially in clockwise order.
  2. Only intersections that the user is approaching directly should be called out.
  3. Some more complex intersections result in repetitive callouts with subsets of the intersecting roads.

The complete logic for this in iOS Soundscape is nontrivial, but is helpfully documented: https://github.com/soundscape-community/soundscape/blob/943ff8a91181f6e8bbd8f74cb338888b9f29f3cf/docs/ios-client/components/intersections-callout-logic.md

@steinbro steinbro self-assigned this Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant