Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of overall maintenance efforts or abandoned? #201

Open
mmzx opened this issue Feb 17, 2020 · 30 comments
Open

Lack of overall maintenance efforts or abandoned? #201

mmzx opened this issue Feb 17, 2020 · 30 comments

Comments

@mmzx
Copy link
Collaborator

mmzx commented Feb 17, 2020

Hi All,

For a while I did not need to install keter, but now I would need it and it seems to have several wounds. Is the project abandoned or would simply just benefit from more regular maintenance?

I would be very happy to help if there is demand for it!

Like,

  • master brach is failiing to build currently
  • CI script has old ghc versions in it
  • maybe there is something useful in the existing pull-requests and some of them could be merged in?
@tolysz
Copy link
Contributor

tolysz commented Feb 17, 2020

I still use it. The challenge is once you build it, there is no need to touch it.
For sure there is something useful in the PRs :P

@mmzx
Copy link
Collaborator Author

mmzx commented Feb 17, 2020

I am setting up a new server at the moment and ended up copying the keter binary from the old server. - which is not ideal. On the current version of FreeBSD the ghc version is actually unavailable (ghc-8.0.2 was used last time); so basically there is no chance I could compile keter on a recent version of this OS, well including Linux as well.

Again, I am happy to work on new PRs as long as the effort makes sense.

@tolysz
Copy link
Contributor

tolysz commented Feb 17, 2020

You could try to build from the:
#195 ( https://github.com/tolysz/keter/tree/modernize )

@mmzx
Copy link
Collaborator Author

mmzx commented Feb 17, 2020

Compiles. Great. Thanks. :)

As a contributor you would be able to merge onto master, right?

@mmzx
Copy link
Collaborator Author

mmzx commented Feb 18, 2020

I have started making small modifications:
@tolysz , baseed on your branch modernize I have found the followings:

  • keter's code is written using Internals of the process library. Which changes actually quiet a bit between versions, so I think it is not a good idea to use the Internal parts of the library. There are unhandled pattern-match warnings because of these changes of the internal API. By pinning process-1.4.3.0 to which originally was written against these issues are resolved easily without any extra consequence.

  • additonally some easy fix is also provided.

  • On top of these by having a new working CI script multiple ghc versions could be tested I think.

  • By pinning process-1.4.3.0 for the time being newer lts versions could be used if needed.

@tolysz
Copy link
Contributor

tolysz commented Feb 20, 2020

Contributor is a label for people who ever got merged into the code... nothing more. You need people with "Collaborator" labels :)

@mmzx
Copy link
Collaborator Author

mmzx commented Feb 20, 2020

Right! I keep putting effort into it, hopefully someone will listen up... - to the noise I make.

@tolysz
Copy link
Contributor

tolysz commented Feb 20, 2020

The modernize branch builds with LTS Haskell 15.0... no need to pin process yet...

@mmzx
Copy link
Collaborator Author

mmzx commented Feb 20, 2020

The modernize branch lacks stack.yaml, so that definitely brakes the builds using stack.

@tolysz
Copy link
Contributor

tolysz commented Feb 20, 2020

stack init && stack setup && stack install
possibly before all that
stack upgrade --git

@mmzx
Copy link
Collaborator Author

mmzx commented Feb 20, 2020

stack init && stack setup && stack install
possibly before all that
stack upgrade --git

Hm. Doing this would be against having pre-defined lts versions: and/or will require lts specific stack configuration files which results in no need to run stack init && stack setup.

@mmzx
Copy link
Collaborator Author

mmzx commented Feb 20, 2020

In #203 it is realized to have resolver specific stack files. Initializing stack config isn't needed any more, indeed it actually may fall back to a too old LTS version in some cases.
I will start adding resolvers and apply fixes to warnings.

@vaclavsvejcar
Copy link

@snoyberg It looks there's still some need for this tool, I also considered using that but on the other hand I don't want to use abandonned software. Do you still plan to maintain this tool? Thanks.

@snoyberg
Copy link
Owner

I passed maintenance of Keter over to @creichert a few years back. I don't know if he is still actively maintaining. If not, and if others want to step up as maintainers, I'm happy to have out maintainer bits.

@mmzx
Copy link
Collaborator Author

mmzx commented Apr 29, 2020

Please, please please! Volunteering.

@lucch
Copy link
Collaborator

lucch commented Apr 29, 2020

There is definitely some need for this tool! 🙂

@mmzx
Copy link
Collaborator Author

mmzx commented Apr 29, 2020

Cross reference to #203.

@creichert
Copy link
Collaborator

Hey all, I am not actively using Keter anymore so of course my maintenance efforts have diminished as my time is required elsewhere.

I will do my best to help any new maintainers come on board and I'm happy to review PRs.

@snoyberg
Copy link
Owner

@mmzx @lucch I've invited both of you as collaborators on this repository.

@benjamingoldstein
Copy link
Contributor

It is good to see this happening.

Did you all get the project back up and running again? I can't seem to run the install instruction command, as per issue #206

@jappeace
Copy link
Collaborator

@mmzx are you still maintaining this? could you please look at the pr's I made?

@mmzx
Copy link
Collaborator Author

mmzx commented Apr 20, 2021

@jappeace , thanks for the direct call-out! I am going to look at the PRs...

@jezen
Copy link
Collaborator

jezen commented Aug 4, 2021

@snoyberg We're using keter regularly at Supercede. Any chance we could also be maintainers of this?

@snoyberg
Copy link
Owner

snoyberg commented Aug 4, 2021

Absolutely, invite sent. Let me know if you want other people on your team to have access too.

@jezen
Copy link
Collaborator

jezen commented Aug 4, 2021

Thanks Michael. The more, the merrier! Relevant people include:

@snoyberg
Copy link
Owner

snoyberg commented Aug 4, 2021

All invited

@jappeace
Copy link
Collaborator

jappeace commented Aug 4, 2021

Could you also make someone hackage maintainer so we can make a release? I have a bunch of nix code I wish to integrate in nixpkgs, that'd be a lot easier if there was a new hackage release. It's possible to run Keter from nixos with that code.

@snoyberg
Copy link
Owner

snoyberg commented Aug 5, 2021

Sure, @jezen can you send me your Hackage username?

@jezen
Copy link
Collaborator

jezen commented Aug 22, 2021

Yep! My username on Hackage is jgt.

Cheers!

@snoyberg
Copy link
Owner

Added :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants