Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sources for fhir-client.js on "Tutorial - Building a JavaScript App" are broken #175

Open
ghost opened this issue Oct 14, 2019 · 4 comments

Comments

@ghost
Copy link

ghost commented Oct 14, 2019

This is link to "Tutorial - Building a JavaScript App"
https://docs.smarthealthit.org/tutorials/javascript/

That page has some references to fhir-client.js file and they are broken, i.e. give 404.

source

https://raw.githubusercontent.com/smart-on-fhir/client-js/master/dist/fhir-client.js

one

https://rawgit.com/smart-on-fhir/client-js/master/dist/fhir-client.js

two

@kolkheang
Copy link

The new version (2.x) has all the files under /dist/build/ where as the old (1.x) has all the files under /dist/.

@fluidguid here is the new URL:
https://raw.githubusercontent.com/smart-on-fhir/client-js/master/dist/build/fhir-client.js

cc: @vlad-ignatov

@ghost
Copy link
Author

ghost commented Oct 15, 2019

Yep, that link works. Thanks @kolkheang. Should I close the issue, or keep it open until the webpage is edited with this note (or new URL)? Sorry, I am not quite familiar yet with all the norms on this platform.

@kolkheang
Copy link

@fluidguid
Let's keep this issue until the link is fixed.

@jmandel
Copy link
Member

jmandel commented Nov 15, 2019

More broadly, navigating from http://docs.smarthealthit.org/ to docs on the new JS library is still very hard. There are a lot of outdated examples that we should (in order of preference):

  • upate to the lastst library
  • annotate with notes pointing to the latest library
  • remove to avoid confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants