You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Deleting the break that happened to be the next scheduled one will remove the break from the existing queue, but keep it as last_break in the BreakQueue.
This leads to an infinite loop in this code:
Ensure that there are exactly two breaks, and delete all breaks except those (eg. "Tightly close your eyes" and "Have some water"). This is needed to increase the likelyhood of the bug happening, but can occur with any number of breaks.
Click on 'Take a break now' -> 'Any Break'.
After the break, open the Settings.
Go to the break list.
Delete either break (eg. "Have some water").
Click "Delete" in the confirmation dialog.
Try to close the settings dialog - this will hang in about 50% of the time.
Since it is a coinflip each time, it is needed to repeat step 2-7 a few times to reproduce.
Expected behavior
Deleting any break should not hang.
Desktop (please complete the following information):
OS: Fedora 39
Desktop Env: KDE Plasma Wayland
Version: Plasma 5.27
Debug Log
Run the Safe Eyes using safeeyes --debug command attach the ~/safeeyes.log` file.
2024-03-06 20:26:18,911 [INFO]:[Thread-7] Start Safe Eyes core
2024-03-06 20:26:18,912 [INFO]:[WorkThread] Waiting for 15 minutes until next break
2024-03-06 20:26:18,912 [INFO]:[MainThread] Update next break information
2024-03-06 20:26:21,881 [INFO]:[MainThread] Show Settings dialog
2024-03-06 20:26:29,394 [INFO]:[MainThread] Saving settings to safeeyes.json
2024-03-06 20:26:29,394 [INFO]:[MainThread] Disable Safe Eyes
2024-03-06 20:26:29,395 [INFO]:[MainThread] Stop Safe Eyes core
2024-03-06 20:26:29,395 [INFO]:[WorkThread] Pre-break waiting is over
2024-03-06 20:26:29,396 [INFO]:[MainThread] Initialize SafeEyesCore with modified settings
2024-03-06 20:26:29,396 [INFO]:[MainThread] Initialize the core
After Initialize the core, it will hang.
The text was updated successfully, but these errors were encountered:
Describe the bug
Deleting the break that happened to be the next scheduled one will remove the break from the existing queue, but keep it as
last_break
in the BreakQueue.This leads to an infinite loop in this code:
SafeEyes/safeeyes/model.py
Lines 110 to 113 in 00c3390
To Reproduce
Steps to reproduce the behavior:
Since it is a coinflip each time, it is needed to repeat step 2-7 a few times to reproduce.
Expected behavior
Deleting any break should not hang.
Desktop (please complete the following information):
Debug Log
Run the Safe Eyes using
safeeyes --debug
command attach the ~/safeeyes.log` file.After
Initialize the core
, it will hang.The text was updated successfully, but these errors were encountered: