generated code outdated

[marinkobabic]

Please can you update your project because it seems to be outdated https://github.com/simonhauck/unofficial-nordigen-api-java/blob/master/generated/src/main/java/org/openapitools/client/model/Status6e6Enum.java

new status has much more values now https://ob.nordigen.com/api/swagger.json Status1c5Enum

[simonhauck]

Thanks for the notification 👍

I updated the generated code. There were some more differences. For example some models were renamed, some additional exceptions were added.

Can you verify with this version, that everything works and give me feedback? Afterwards i would create a new release.
dependencies { implementation 'com.github.simonhauck:unofficial-nordigen-api-java:master-0228fea93e-1' }

[marinkobabic]

Thanks. Looks good. I haven't implemented all the parts of Nordigen API so I'm not able to prove everything. Just started with the implementation. Thanks a lot for your support.

…

On Sun, 26 Dec 2021, 17:14 simonhauck ***@***.***> wrote: Thanks for the notification 👍 I updated the generated code. There were some more differences. For example some models were renamed, some additional exceptions were added. Can you verify with this version, that everything works and give me feedback? Afterwards i would create a new release. dependencies { implementation 'com.github.simonhauck:unofficial-nordigen-api-java:master-0228fea93e-1' } — Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAY5EOD6QAIAT3CD5M2B3BDUS45QHANCNFSM5KY6VNXQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[marinkobabic]

It seems like ssn can't be anymore null even if it's defined as optional
"optional SSN field to verify ownership of the account"

[marinkobabic]

I don't think this definition is correct https://github.com/simonhauck/unofficial-nordigen-api-java/blob/master/generated/src/main/java/com/github/simonhauck/unofficial/nordigen/api/PremiumApi.java

There are a lot of void responses. Where do you get the yaml file from, in order to generate the API? It seems like they have one here https://ob.nordigen.com/api/swagger.yaml but it's not valid.

[simonhauck]

I converted the json to yaml.
marinkobabic - but it's not valid.
And yes thats the main problem. The specification is not correct... thats what makes our life way harder.
I removed some optional fields, because somehow it lead to compile errors in the generated code.

I will try to revert that commit and resolve the issues in the next days :)
If you want to be proactive, you can also create a pull request :)

[marinkobabic]

I will talk with Nordigen so that we can get here some support and an official yaml file. I did also some testing. When ssn is specified, then I'm getting a message that the selected bank is not supporting ssn. When setting ssn to null or empty string, then the error is reported that the field must be specified. Have reported this issue to Nordigen.

[marinkobabic]

Just a hint. RequisitionV2 constains now the field SSN. Even if the value is not set in the code, but the serializer should create such a field with a null value, then the API call is failing. If the value null for this field is not sent over wire, then the request works. This means for you just make ssn field nullable: true before generating the code

[simonhauck]

sorry for the late reply (you know holidays and stuff :D )

So do i understand correctly. I should only add the nullable: true for the ssn field?

[marinkobabic]

Yes. Your understanding is correct. Nordigen will by the way check their yaml file. They should provide a lot more schemas. The actual definition is useless.

…

On Thu, 30 Dec 2021, 16:44 simonhauck ***@***.***> wrote: sorry for the late reply (you know holidays and stuff :D ) So do i understand correctly. I should only add the nullable: true for the ssn field? — Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAY5EOEI4EHX6E6WTUABNLDUTR467ANCNFSM5KY6VNXQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[simonhauck]

That would make this way easier 👍 Thanks!

i will try to resolve some other compilation errors and then i will notify you with a new version

[simonhauck]

can you please test again with com.github.simonhauck:unofficial-nordigen-api-java:3e3e0e223f