Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong validation of spec.kubernetes.logRetentionDays #287

Open
g-iannelli opened this issue Feb 21, 2023 · 1 comment
Open

Wrong validation of spec.kubernetes.logRetentionDays #287

g-iannelli opened this issue Feb 21, 2023 · 1 comment
Labels
bug Something isn't working furyctl-ng size/S

Comments

@g-iannelli
Copy link
Contributor

spec.kubernetes.logRetentionDays doesn't validate the value passed as input.

Only possible values are : 1, 3, 5, 7, 14, 30, 60, 90, 120, 150, 180, 365, 400, 545, 731, 1096, 1827, 2192, 2557, 2922, 3288, 3653

Terraform resource accept also 0

If you select 0, the events in the log group are always retained and never expire.
@g-iannelli g-iannelli added bug Something isn't working furyctl-ng labels Feb 21, 2023
@g-iannelli
Copy link
Contributor Author 

 cat barebone.eu-west-1.yml| yq -e .spec.kubernetes.logRetentionDays && furyctl-ng validate config -c barebone.eu-west-1.yml --distro-location 'git::git@github.com:sighupio/fury-distribution.git?depth=1&ref=feature/furyctl-next'
3654
INFO Downloading distribution...
INFO configuration file validation succeeded

@omissis omissis added the size/S label Feb 28, 2023
ralgozino added a commit to sighupio/fury-distribution that referenced this issue Nov 11, 2024
@ralgozino
feat(docs/schema): improve eks, kfdisitribution schema docs
faa3966 
Port the improvements done for on-prem schema in #268 to the EKS and KFDDistribution schemas and banners used to render the markdown.

Some minor improvements to On-premises too.

fixes sighupio/product-management#543 sighupio/furyctl#287
ralgozino added a commit to sighupio/fury-distribution that referenced this issue Nov 11, 2024
@ralgozino
feat(docs/schema): improve eks, kfdisitribution schema docs
44ffd2a 
Port the improvements done for on-prem schema in #268 to the EKS and KFDDistribution schemas and banners used to render the markdown.

Some minor improvements to On-premises too.

fixes sighupio/product-management#543 sighupio/furyctl#287
@ralgozino ralgozino mentioned this issue Nov 11, 2024
Merged
ralgozino added a commit to sighupio/fury-distribution that referenced this issue Nov 11, 2024
@ralgozino
feat(docs/schema): improve eks, kfdisitribution schema docs
0a130e4 
Port the improvements done for on-prem schema in #268 to the EKS and KFDDistribution schemas and banners used to render the markdown.

Some minor improvements to On-premises too.

fixes sighupio/product-management#543 sighupio/furyctl#287
ralgozino added a commit to sighupio/fury-distribution that referenced this issue Nov 25, 2024
@ralgozino
feat(docs/schema): improve eks, kfdisitribution schema docs
7c21c5e 
Port the improvements done for on-prem schema in #268 to the EKS and KFDDistribution schemas and banners used to render the markdown.

Some minor improvements to On-premises too.

fixes sighupio/product-management#543 sighupio/furyctl#287
ralgozino added a commit to sighupio/fury-distribution that referenced this issue Nov 25, 2024
@ralgozino
feat(docs/schema): improve eks, kfdisitribution schema docs
1bc104f 
Port the improvements done for on-prem schema in #268 to the EKS and KFDDistribution schemas and banners used to render the markdown.

Some minor improvements to On-premises too.

fixes sighupio/product-management#543 sighupio/furyctl#287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working furyctl-ng size/S
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@omissis @g-iannelli