Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppet agent 8 throws a warning when it interpolates the template sensu/agent.yaml.erb #1341

Open
maxadamo opened this issue Apr 3, 2024 · 3 comments
Assignees

Comments

@maxadamo
Copy link
Contributor

maxadamo commented Apr 3, 2024

Description of problem

  • puppet agent 8 emits a warning while it's interpolating the template sensu/agent.yaml.erb

Command used and debugging output

puppet agent -t --debug

Debug: Datacat_collector[sensu_agent_config](provider=datacat_collector): Collected {"backend-url"=>["wss://uat-sensu01.xxxxx.org:8081", "wss://uat-sensu02.xxxxx.org:8081", "wss://uat-sensu03.xxxxx.org:8081"], "name"=>"test-consul01.xxxxx.org", "agent-managed-entity"=>true, "subscriptions"=>["devops_linux", "linux_metrics", "vmware", "devops_linux", "linux_metrics", "vmware"], "annotations"=>{"place"=>"holder", "puppet_board"=>"https://puppetboard.xxxxx.org/test/node/test-consul01.xxxxx.org", "performance_board"=>"https://metrics.xxxxx.org/d/DsGCxmXZz/resources-utilization?orgId=1&var-server_name=test-consul01_xxxxx_org", "What does this server do?"=>"https://wiki.xxxxx.org/dosearchsite.action?cql=siteSearch+~+%22consul%22&queryString=consul"}, "labels"=>{"host_name"=>"test-consul01", "fqdn"=>"test-consul01.xxxxx.org", "ip_address"=>"xxxxxxxxxx", "ip6_address"=>"xxxxxxxxxxx", "reboot_required"=>"false", "security_update_count"=>"0", "domain_password"=>"xxxxxxxxxxxxxxxx", "snmp_community"=>"xxxxxxxxxxxx", "environment"=>"test", "nagios_check_path"=>"/usr/lib/nagios/plugins", "fqdn_metrics_label"=>"test-consul01_xxxxx_org", "os_name"=>"Ubuntu", "os_version"=>"20.04", "hostgroup"=>"consul", "served_domain"=>"consul.xxxxx.org", "memory_limit"=>"-w 85 -c 90", "swap_limit"=>"-w 15% -c 10%"}, "namespace"=>"default", "redact"=>["monitor_password", "domain_password", "password", "passwd", "pass", "api_key", "api_token", "access_key", "secret_key", "private_key", "secret", "snmp_community", "gandi_api_key"], "password"=>"xxxxx", "trusted-ca-file"=>"/etc/sensu/ssl/ca.crt", "statsd-event-handlers"=>["influxdb_stats", "influxdb_sensu_events"], "keepalive-critical-timeout"=>60, "keepalive-warning-timeout"=>40, "keepalive-handlers"=>["devops_email", "it_email", "slack", "squadcast-general"]}
Debug: Datacat_collector[sensu_agent_config](provider=datacat_collector): Applying template sensu/agent.yml.erb
/opt/puppetlabs/puppet/cache/lib/puppet/provider/datacat_collector/datacat_collector.rb:31: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
/opt/puppetlabs/puppet/cache/lib/puppet/provider/datacat_collector/datacat_collector.rb:31: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.

Platform and version information

  • Your OS: Linux
  • Your Ruby version: $(/opt/puppetlabs/puppet/bin/ruby --version) ruby 3.2.3
  • Your version of Puppet: Puppet community edition 8.5
  • Your version of Sensu: 6.10.0-7172
  • Your version of this module: 5.11.1
@maxadamo maxadamo changed the title Puppet agent 8 throws a warning while it interpolates the template sensu/agent.yaml.erb Puppet agent 8 throws a warning when it interpolates the template sensu/agent.yaml.erb Apr 4, 2024
@ManishaKumari295 ManishaKumari295 self-assigned this May 7, 2024
@maxadamo
Copy link
Contributor Author

maxadamo commented Dec 3, 2024

@ManishaKumari295 this issue is caused by datacat module being deprecated: https://forge.puppet.com/modules/richardc/datacat/readme

I can try to fork datacat module and have a look.

@maxadamo
Copy link
Contributor Author

maxadamo commented Dec 4, 2024

@ManishaKumari295 a possible solution consists of switching from datacat module to puppet-colections module, hence switching from ERB to EPP.

Could you also please revert the change below? This default value is not appropriate for a public module:

Optional[Stdlib::Absolutepath] $package_download_path = '/home/ubuntu/.puppetlabs/etc/code/modules',

@ManishaKumari295
Copy link

@maxadamo thanks for the response and suggestions. I am checking if puppet-collections or puppetlabs/conact will be able to replace datacat module. Shall proceed with the changes and let you know once done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants