Menu item to select the default currency symbol

[andrewtavis]

Terms

• I have searched open and closed feature requests
• I agree to follow Scribe-iOS' Code of Conduct

Description

This issue would create a menu item whereby the user would be taken to a separate screen to select a default currency symbol for the keyboard that appears on the 123 keys. The process is detailed in the designs in Figma. The option would be in general keyboard settings and for those on a per-keyboard basis.

• Blocked by Add menu to Scribe app #16 and Base menu item component with info tooltip #309

Contribution

This issue is a part of Google Summer of Code 2023 😊 Happy to assist as needed!

[andrewtavis]

Place that this is shown in the Figma is: https://www.figma.com/file/c8945w2iyoPYVhsqW7vRn6/scribe_public_designs?type=design&node-id=513%3A1616&mode=design&t=dh3jyNuvsEhKhmR2-1

[lillian-mo]

I would be happy to work on this issue :)

[vickcoo]

Hello @andrewtavis 👋🏻, I would like try to work on this.

[andrewtavis]

Nice @vickcoo! Would be great to get this added in :) In thinking on it, we might need #476 merged in as that has the code to make the radio button menus. Do you want to look into the code there a bit and also at what would be needed for #238 that would implement actually changing the main currency symbol? Note that the change here is only for iPhones as iPads have them all on one view :)

[andrewtavis]

If all sounds good, feel free to write in #238 and I'll assign that one too! Then we can work to get both of these done! For that one the question is how to make the currency symbol on the number keys variable and replace it with a different one while also updating those that are on the symbol keys :)

[vickcoo]

So, do you mean we need to merge #476 before starting this issue, or do you just want me to reference it first?
And I need a little time to figure out #238, because I'm not sure what the difference between this issue and that one.
btw, my English isn't very good, so I might not fully understand what you mean 🫣

[andrewtavis]

No worries whatsoever, @vickcoo! At least on my end I'm understanding you well, and happy to explain things as needed to make things clear 😊

What I'm considering is:

• You're right that we need to merge System to pick a translation language for each keyboard #476 before this one as it has code that we need
• The differences between this issue and Allow for currency symbol selection #238 are:
  • This issue is to add the menu option to select the currency symbol (change is within Scribe-iOS/Scribe, the application's menu)
  • Allow for currency symbol selection #238 is to reflect the change of the currency symbol in the keyboard UI (change is within Scribe-iOS/Keyboards, the change on the keyboards based on the menu selection here)

What you could do is look into the places that would need the change in #238 and we could discuss them over there? Let me head over and document it a bit for you :)

[vickcoo]

Thanks for your patience and explanation @andrewtavis ! I got it. Let's discuss it further over there, Here's a summary of the steps as I understand them

1. solve the Allow for currency symbol selection #238
2. wait for System to pick a translation language for each keyboard #476 merged
3. solve this issue

[andrewtavis]

Yes you can definitely solve #238 in the meantime, and the other PR should be in by the end of the week 😊 Thanks, @vickcoo!

[andrewtavis]

Hey @vickcoo 👋 The fall has been quite busy for other projects, but we finally got #476 merged in :) Would you have interest in working on this now?

[vickcoo]

Hey @vickcoo 👋 The fall has been quite busy for other projects, but we finally got #476 merged in :) Would you have interest in working on this now?

Hi @andrewtavis , I'm glad to hear that issue is resolved. I'll work on this one. 😄

[andrewtavis]

Nice! Looking forward, @vickcoo 😊