Add the menu option to set Translation source

[angrezichatterbox]

Terms

• I have searched open and closed feature requests
• I agree to follow Scribe-Android's Code of Conduct

Description

Currently the individual language settings doesn't allow the user to set the translation source for each language keyboard settings. The issue aims to add the ability to set translation source language for each language keyboard separately. This could be stored in the shared preferences for now for each language separately similar to how it is being done for period_on_double_tap.

A visual reference of how this option would look is given below.

Contribution

I would love to work on this and am more than happy to help anyone fix this issue :)

[ThousandYearGrind]

@henrikth93, Hi, does this work?

[henrikth93]

@henrikth93, Hi, does this work?

Should work now!

[andrewtavis]

Hey @ThousandYearGrind 👋 Quick note that this issue is now just to add the menu option that selects from a list, so at the end of it we want the menu option that's shown in the issue text and the interface like this in the Figma designs. Actually switching the translation language will be handled by #265 once this issue is finished - i.e. this issue is for the interface and #265 is for the functionality.

[ThousandYearGrind]

Ahhh, thank you. I was scratching my head over that for a while.

[ThousandYearGrind]

@andrewtavis How should I approach translations? Can I just run "Translation source language" through google translate or should this be done later by someone else?

[andrewtavis]

We'll have local translations for this, @ThousandYearGrind :) This issue is just for the menu option to select the base language.

[ThousandYearGrind]

Hi @andrewtavis, where would be a good place to ask code-specific questions? I've been trying to figure out how to do something for a while.

[andrewtavis]

@ThousandYearGrind, asking them here would be good, that way it's easy for us to link to files :)

[ThousandYearGrind]

@andrewtavis So I've added the option for the settings screen using a ClickableItem like the app language setting. Now, I need to set the action that takes place when the user clicks on the setting.

val appSettingsItemList =
        listOf(
            ScribeItem.ClickableItem(
                title = stringResource(R.string.app_settings_menu_app_language),
                desc = stringResource(R.string.app_settings_menu_app_language_description),
                action = onLanguageSelect,
            ),
            ScribeItem.SwitchItem(
                title = stringResource(R.string.app_settings_menu_app_color_mode),
                desc = stringResource(R.string.app_settings_menu_app_color_mode_description),
                state = isUserDarkMode,
                onToggle = { isUserDarkMode1 ->
                    onDarkModeChange(isUserDarkMode1)
                },
            ),
            ScribeItem.SwitchItem(
                title = stringResource(R.string.app_settings_keyboard_keypress_vibration),
                desc = stringResource(R.string.app_settings_keyboard_keypress_vibration_description),
                state = vibrateOnKeypress.value,
                onToggle = { shouldVibrateOnKeypress ->
                    vibrateOnKeypress.value = shouldVibrateOnKeypress
                    PreferencesHelper.setVibrateOnKeypress(context, shouldVibrateOnKeypress)
                },
            ),
            ScribeItem.SwitchItem(
                title = stringResource(R.string.app_settings_keyboard_functionality_popup_on_keypress),
                desc = stringResource(R.string.app_settings_keyboard_functionality_popup_on_keypress_description),
                state = popupOnKeypress.value,
                onToggle = { shouldPopUpOnKeypress ->
                    popupOnKeypress.value = shouldPopUpOnKeypress
                    PreferencesHelper.setShowPopupOnKeypress(context, shouldPopUpOnKeypress)
                },
            ),
            ScribeItem.ClickableItem(
                title = stringResource(R.string.app_settings_menu_translation_language),
                desc = stringResource(R.string.app_settings_menu_translation_language_description),
                action = onTranslationLanguageSelect,
            ),
        )

I looked at the app language setting's action and it uses an intent, but I'm not sure how to do this for the translation language setting.

    private fun selectTranslationLanguage() {
        
    }

    private fun selectLanguage() {
        val packageName = requireActivity().packageName
        val intent =
            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
                Intent(ACTION_APP_LOCALE_SETTINGS)
            } else {
                Intent(ACTION_APPLICATION_DETAILS_SETTINGS).apply {
                    data = Uri.fromParts("package", packageName, null)
                    putExtra(
                        "android.intent.extra.SHOW_FRAGMENT",
                        "com.android.settings.localepicker.LocaleListEditor",
                    )
                }
            }
        intent.data = Uri.fromParts("package", packageName, null)
        startActivity(intent)
    }

[andrewtavis]

Hey @ThousandYearGrind 👋 Firstly, could we get this menu option moved into the settings for each language keyboard, so it wouldn't be on settings, but on your screen it would be in French and English. We made the decision to have it there as there are members of the community who would translate from different languages: say French to Spanish and English to German.

From there we won't be having it function like the app's language selection. Clicking that option will take the user to a sub menu with radio options. Maybe you can make the change for the menu option location and then open a PR and we can then assist on making the radio option menu?

[ThousandYearGrind]

@andrewtavis I've done as you suggested and moved the menu option to the language keyboard. Should I submit a PR now?

[andrewtavis]

We're basically there, @ThousandYearGrind! Could you refer to where it should be located in the designs for this tab? Pasting an image of its location in its own sub menu below as well:

Feel free to open a PR once it's been moved!

[andrewtavis]

And thanks for your persistence here!