Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-488 - As a developer (Ben) I would like to update the way the Aliquot table accepts data so that aliquot updates can be correctly reflected. #699

Open
4 tasks
BenTopping opened this issue Dec 2, 2024 · 0 comments
Assignees
Labels
Size: M Medium - medium effort & risk Value: 4 Value to the insitute is high Volume tracking Volume tracking

Comments

@BenTopping
Copy link
Contributor

User story

As a developer (Ben) I would like to update the way the Aliquot table accepts data so that aliquot updates can be correctly reflected. In the current implementation we only create a record if there is a new UUID for the aliquot. However Traction does not change the UUID if an existing aliquot's data changes, for example a volume update, in which case the aliquot is not created in the warehouse.

In the new implementation we would like the Aliquot table to create a new record if ANY of its values change. This allows us to create new records for aliquot updates and it maintains an audit of updates.

Who are the primary contacts for this story
Ben T, Seena N, Steve I

Acceptance criteria

Consider if these features can be featured flagged to decouple testing and deployment.
To be considered successful the solution must allow:

  • Aliquot table creates a new record if an existing aliquot has updated data
  • Aliquot table does not create a new record if an existing aliquot has no updated data.
  • Nuke the existing table data.
  • Repopulate the data via Traction rake task.

Additional context
This came out of research into the Aliquot table behaviour during sanger/traction-service#1458 when attempting to update values was causing issues.

@BenTopping BenTopping added Size: S Small - low effort & risk Value: 4 Value to the insitute is high Volume tracking Volume tracking Size: M Medium - medium effort & risk and removed Size: S Small - low effort & risk labels Dec 2, 2024
@psd-issuer psd-issuer bot changed the title As a developer (Ben) I would like to update the way the Aliquot table accepts today so that aliquot updates can be correctly reflected. Y24-488 - As a developer (Ben) I would like to update the way the Aliquot table accepts today so that aliquot updates can be correctly reflected. Dec 2, 2024
@BenTopping BenTopping changed the title Y24-488 - As a developer (Ben) I would like to update the way the Aliquot table accepts today so that aliquot updates can be correctly reflected. Y24-488 - As a developer (Ben) I would like to update the way the Aliquot table accepts data so that aliquot updates can be correctly reflected. Dec 2, 2024
@seenanair seenanair self-assigned this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: M Medium - medium effort & risk Value: 4 Value to the insitute is high Volume tracking Volume tracking
Projects
None yet
Development

No branches or pull requests

2 participants