Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-479 - As a developer (Ben) I would like to refactor Aliquot polymorphism in the API. #1493

Open
BenTopping opened this issue Nov 26, 2024 · 0 comments
Labels
Pacbio Size: M Medium - medium effort & risk Technical Debt Technical Debt Value: 3 Value to the insitute is average

Comments

@BenTopping
Copy link
Collaborator

BenTopping commented Nov 26, 2024

Describe the Housekeeping
As a developer (Ben) I would like to refactor Aliquot polymorphism in the API. Currently in the Aliquot JSON::API resource we are doing some work arounds to allow the source and used_by polymorphic relationships. See Aliquot model comments and PacBio Aliquot resource. We should not have to set these relationships as it should work without them.

The current workarounds also do not allow nested includes, for example source.tube does not work, as explained here. Nested includes would help simplify querying the polymorphic data.

We would like to see if this can be updated / improved so we don't have to set the types explicitly or do some hacky json api polymorphism fixes and allow us to do nested includes for polymorphic relationships.

Additional notes
JSON::API resources is not very actively maintained at the moment but there are some candidate releases that appear to address some of these issues so it is worth looking into those.

@BenTopping BenTopping added Pacbio Size: M Medium - medium effort & risk Value: 3 Value to the insitute is average labels Nov 26, 2024
@psd-issuer psd-issuer bot changed the title As a developer (Ben) I would like to refactor Aliquot polymorphism in the API. Y24-479 - As a developer (Ben) I would like to refactor Aliquot polymorphism in the API. Nov 26, 2024
@stevieing stevieing added the Technical Debt Technical Debt label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pacbio Size: M Medium - medium effort & risk Technical Debt Technical Debt Value: 3 Value to the insitute is average
Projects
None yet
Development

No branches or pull requests

2 participants