Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-nnn Possible redundant fact creation in actions.rb #183

Open
JamesGlover opened this issue Apr 14, 2022 · 0 comments
Open

DPL-nnn Possible redundant fact creation in actions.rb #183

JamesGlover opened this issue Apr 14, 2022 · 0 comments

Comments

@JamesGlover
Copy link

Describe the Housekeeping

When running some of the rubocop auto-fixes, I noticed this:

assets.each do |asset|
each_connected_asset(assets, destinations, wildcard_values) do |s, d|
updates.add(s, predicate, d)
end
end

The yielded asset is unused, and instead assets gets passed into `each_connected_asset. This will need to be evaluated to make sure we aren't creating asset*asset facts unnecessarily. It can then either be fixed, or annotated with a clear explanation.

Blocking issues
Describe any other issues or tickets that may be blocking this change.

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant