Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-464 - Create multiple plates in pending state at once #2076

Open
9 tasks
yoldas opened this issue Nov 18, 2024 · 4 comments
Open
9 tasks

Y24-464 - Create multiple plates in pending state at once #2076

yoldas opened this issue Nov 18, 2024 · 4 comments
Labels
EMSeq ToR 170 Enhancement New feature or request Should've MoSCoW Prioritization - Should Have Capability/Feature Size: M Medium - medium effort & risk

Comments

@yoldas
Copy link
Member

yoldas commented Nov 18, 2024

User story

As Limber user running LCM Triomics EMSeq and WGS pipeline, I would like to create multiple successive plates in pending state at once and print barcodes.

"To generate the LCMT DNA Frag, LCMT DNA End Prep, LCMT DNA Adp Lig, LCMT TET2 Ox & LCMT TET2 Stop plates at the beginning of the process required me to serially ‘Add an empty LCMT X plate’ on each parent plate to create each child plate in turn, and separately print barcodes each time."

Who are the primary contacts for this story

Scott G.
Abdullah

Who is the nominated tester for UAT

Scott G.

Acceptance criteria

To be considered successful the solution must allow:

Option 1) A create button on a parent plate triggers the labware creation immediately and shows the child plates in a custom page and allows printing barcodes. (create and show actions).

  • There is a button with a configured text on the sidebar to open a custom page to create successive child plates in pending state. For example, such a button (with the text Bravo Initial Setup) for the setup will be available on the LCMT Lysate plate to create LCMT DNA Frag, LCMT DNA End Prep, LCMT DNA Adp Lig, LCMT TET2 Ox & LCMT TET2 Stop child plates, and also another (with the text Bravo LCMT EM TET2 Stop to Denat and Deam Setup) on LCMT EM TET2 Stop to create LCMT EM NaOH Denat and LCMT EM APOBEC Deam child plates.
  • The custom page is backed by a specialised labware creator to create and link successive child plates of configured purposes.
  • The custom page lists the children barcodes, and a form to print all barcodes at once.
  • The custom page has links to the individual labware pages.
  • The purpose config of the parent plate contains a section for the specialised labware creator, and child purposes and button text as arguments.
  • The parent plate presenter renders an additional section in the sidebar for the feature and shows the button.

Option 2) A create button on a parent plate opens an intermediate page to present the configuration for the child creation and a Create button. This intermediate page corresponds to new action of the controller. Once the button is clicked, it presents another page with the same functionality in option 1 (create and show actions). Having an intermediate page is to present the description of the action and configuration before the labware creation.

Once the feature is implemented (Use them while developing and testing as well):

  • Use it to create LCMT DNA Frag, LCMT DNA End Prep, LCMT DNA Adp Lig, LCMT TET2 Ox & LCMT TET2 Stop from LCMT Lysate
  • Use it to create LCMT EM NaOH Denat and LCMT EM APOBEC Deam from LCMT EM TET2 Stop
  • The integration suite test for LCM Triomics is updated to use the new feature to create the plates in pending state all at once instead of one by one creation.

Dependencies

This story is blocked by the following dependencies:
N/A

References
This story has a non-blocking relationship with:

  • #<issue_no.>
  • sanger/limber#4288

Additional context

This is a generic feature which may be useful to create multiple child labware at once but but it aims to solve a specific issue in the UX of the LCM Triomics EMSeq and WGS pipeline because the existing functionality makes the user jump from page to page to create new plates and print barcodes which is time consuming and error prone.

The feature can be implemented as a Concern to be included in a presenter to handle the specialised labware configuration and present a new card in sidebar for the button.

@yoldas yoldas added EMSeq ToR 170 Size: M Medium - medium effort & risk labels Nov 18, 2024
@psd-issuer psd-issuer bot changed the title Create multiple plates in pending state at once Y24-464 - Create multiple plates in pending state at once Nov 18, 2024
@yoldas yoldas added Enhancement New feature or request Should've MoSCoW Prioritization - Should Have Capability/Feature labels Nov 20, 2024
@KatyTaylor
Copy link
Contributor

I like the ideas. Should be useful wherever we are currently using Permissive Presenters - as a replacement for them maybe, or an alternative.

There's some duplication in the acceptance criteria for Option 1).

@yoldas
Copy link
Member Author

yoldas commented Nov 20, 2024

@KatyTaylor I have removed the duplicate criteria item for option 1).

This story also assumes that the plates to be created do not have a custom creation page to collect additional input for the child plates but such a feature could be implemented as part of option 2).

@KatyTaylor
Copy link
Contributor

This story also assumes that the plates to be created do not have a custom creation page to collect additional input for the child plates but such a feature could be implemented as part of option 2).

That sounds complicated, I wonder if any of our existing labware with permissive presenters have custom creation pages... Feels like often they would require the transfer to have happened already.

@yoldas
Copy link
Member Author

yoldas commented Dec 2, 2024

This story assumes that the plates to be created do not have a custom creation page. I have just mentioned how collecting additional input would be possible but this story does not aim that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EMSeq ToR 170 Enhancement New feature or request Should've MoSCoW Prioritization - Should Have Capability/Feature Size: M Medium - medium effort & risk
Projects
None yet
Development

No branches or pull requests

2 participants