Y24-051 [BUG] Limber can display an incorrect nonexistent pool and incorrect warnings for some stock plates.

[TWJW-SANGER]

Describe the bug
Limber can display an incorrect nonexistent pool and incorrect warnings for some stock plates.

RT Ticket Number
800530

To Reproduce
It is not clear exactly why or when this happens but it seems to be related to stock plates that are not part of Limber pipelines.
The RT contains a number of example plates that have this problem.

Expected behaviour
Limber should be clear that displayed pools will happen in the future.
Limber should be clear that displayed pools have already happened.
Limber should not display pool information on plates that do not have pools or do not have pools scheduled.
Limber should not display incorrect "Libraries are completed" warnings because a plate has completed creation requests.
Limber should fail gracefully and display useful error messages if unexpected conditions or data arise.
Logic for showing next steps button should be consistent with logic showing warnings.

Screenshots
Screenshots are contained in the related RT ticket

Desktop (please complete the following information):

Additional context

[stevieing]

Only fixed in 1 view so we need to fix it for other views.

[StephenHulme]

There appears to be opened requests for the receptacles on the provided plate, see https://sequencescape.psd.sanger.ac.uk/labware/27547942
According to #1679 the Pools tab shows future (planned) pools rather than current pools, I think it would be a good idea to indicate this more clearly on the tab label.

See #2080 for a proposed message

[TWJW-SANGER]

I have updated the acceptance criteria on this story to reflect the fact that the probable intention is to show pools in the future.
Of course, that then raises the question of how to display pooling that has already happened or if we want to.

[StephenHulme]

PR merged too early, reverted and recreated

[StephenHulme]

Summary from RT ticket:

Katy and Andrew have had a look into this and we have concluded that in this case Limber is displaying incorrect/misleading information for plates that do not yet have an uploaded manifest.

Andrew has tried creating new stock plates with and without samples and no pools are created in the databases.

...

So to summarise - pools are not automatically created for stock plates but Limber is displaying misleading/incorrect info. We will create a bug story to fix the information displayed in Limber for these plates. [this bug story]

[KatyTaylor]

Update from chat with @StephenHulme .

Existing functionality:

• When you load up a labware page in Limber, it runs some logic to figure out what pipeline it's part of, so that it can display the next step in the 'suggested actions' section. (This looks at the purpose, request type and library type and matches that up to the piepline config files)

Potential solution for this story:

• Re-using that existing logic, if it cannot figure out what pipeline it's part of, then DON'T display the pooling tab.
• That would hopefully solve the problem with 'stock' plates, because stock plates are not normally part of Limber pipelines.

Potential extension - could be a second story:

• Extending the above logic, having figured out what pipeline it's part of, it could look down that pipeline to see if any of the descendent labware use the 'PooledTubesBySubmission' labware creator.
• If they do, the pooling tab is relevant and should be displayed.
• If they don't the pooling tab is irrelevant and should be hidden.
• This works on the assumption that the pooling tab uses submissions to show which pools the wells will be part of - and that the 'PooledTubesBySubmission' is the only labware creator that creates pools this way. I think this is correct, but haven't looked at the code to make sure.

[TWJW-SANGER]

Just a note this issue #2110, seems like a similar problem where an incorrect warning is displayed but the button logic allows the plate to continue and is in fact fine.

[StephenHulme]

Not yet closed - Github got a little ahead of itself.