Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-1088 [Baracoda] Enable dependency updates #451

Open
5 tasks done
yoldas opened this issue Feb 2, 2024 · 1 comment
Open
5 tasks done

DPL-1088 [Baracoda] Enable dependency updates #451

yoldas opened this issue Feb 2, 2024 · 1 comment
Assignees
Labels
dependencies Pull requests that update a dependency file Housekeeping

Comments

@yoldas
Copy link
Member

yoldas commented Feb 2, 2024

Describe the Housekeeping
As developer (ay6) I would like to the dependency updates enabled which are currently disabled or blocked because of major version changes and test failures.

Acceptance Criteria

  • Update Flask and werkzeug versions gradually. See the next items.
  • Review tests for the error responses (400, 422, and 500). Check if Flask update changes the code for a service error.
  • Review the use of GET or POST requests interchangeably, either use one of the methods or make sure they behave the same
  • Upgrade SQLAlchemy from version 1.4 series to 2.0 series. This is a major change in database access.
  • Apply other dependency updates (dependabot PRs)

Blocking issues
No blocking issue

Additional context
Flask update might make the service return a different error status code for example HTTP_UNPROCESSABLE_ENTITY (422), HTTP_BAD_REQUEST (400), INTERNAL_SERVER_ERROR (500), which causes test failure. Overall, using GET and POST requests interchangeably needs to be reviewed along with the response codes.

@yoldas yoldas changed the title DPL-1088 [Baracoda] dependency updates DPL-1088 [Baracoda] Enable dependency updates Feb 2, 2024
@yoldas
Copy link
Member Author

yoldas commented Feb 14, 2024

Tasks:

  • Clone baracoda, install test environment
  • Apply simple dependabot PRs.
  • Update black PR and ask for review and apply
  • Update sqlalchemy PR and ask for review and apply
  • Refactor error responses in GET/POST methods

@dasunpubudumal dasunpubudumal self-assigned this Feb 14, 2024
@yoldas yoldas added dependencies Pull requests that update a dependency file Housekeeping labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Housekeeping
Projects
None yet
Development

No branches or pull requests

2 participants