Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashes when switching wallet network while executing a recovery transaction #4196

Open
jmealy opened this issue Sep 18, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jmealy
Copy link
Contributor

jmealy commented Sep 18, 2024

Bug description

While a recovery transaction is being executed, if you are connected with the original signer of the safe and you switch network in your connected EOA, then the app will crash. Likely a memory leak.

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: Ethereum mainnet

Steps to reproduce

#4187 (comment)

  1. Create a recovery attempt with wallet B
  2. Switch to wallet A who is an owner and go to queue
  3. Switch wallet A network to something other than the safe

Expected result

Recovery executes without issue

Obtained result

The app crashes

@jmealy jmealy added the bug Something isn't working label Sep 18, 2024
@github-project-automation github-project-automation bot moved this to New issues in Safe{Wallet} Sep 18, 2024
@katspaugh katspaugh moved this from New issues to Todo in Safe{Wallet} Sep 18, 2024
@liliya-soroka
Copy link
Member

18.11.24

@usame-algan usame-algan moved this from Todo to In Progress in Safe{Wallet} Jan 8, 2025
@usame-algan usame-algan self-assigned this Jan 8, 2025
@usame-algan usame-algan moved this from In Progress to Todo in Safe{Wallet} Jan 8, 2025
@usame-algan usame-algan removed their assignment Jan 8, 2025
@usame-algan
Copy link
Member

usame-algan commented Jan 8, 2025

Can confirm that this still happens. I tested it with both an old safe and a brand new safe where I set up Recovery and went through the steps so it is unrelated to how we fetch the recovery state.

The issue lies somewhere in waitForRecoveryTx or one of the listeners of those events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

3 participants