Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deploymentType property to the missing kits #1025

Closed
dasanra opened this issue Oct 25, 2024 · 0 comments · Fixed by #1032
Closed

Add deploymentType property to the missing kits #1025

dasanra opened this issue Oct 25, 2024 · 0 comments · Fixed by #1032
Assignees
@yagopv

Comments

@dasanra
Copy link
Collaborator

dasanra commented Oct 25, 2024

Context / issue

The deploymentType is not usable from the relay-kit and sdk-starter-kit. We need to allow setting the deployment type when the protocol-kit is used from those kits.

Proposed solution

Add the deploymentType property to the Predicted Safe configuration.
@DaniSomoza DaniSomoza self-assigned this Oct 28, 2024
@yagopv yagopv assigned yagopv and unassigned DaniSomoza Oct 31, 2024
@yagopv yagopv linked a pull request Oct 31, 2024 that will close this issue
feat: Add deploymentType #1032
Merged
@yagopv yagopv removed a link to a pull request Oct 31, 2024
feat: Add deploymentType #1032
Merged
@yagopv yagopv linked a pull request Nov 7, 2024 that will close this issue
feat: Add deploymentType #1032
Merged
@dasanra dasanra closed this as completed Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yagopv yagopv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add deploymentType safe-global/safe-core-sdk
4 participants
@yagopv @dasanra @DaniSomoza and others