Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support execute transactions from Trezor. #326

Closed
moisses89 opened this issue Dec 15, 2023 · 3 comments · Fixed by #337
Closed

Support execute transactions from Trezor. #326

moisses89 opened this issue Dec 15, 2023 · 3 comments · Fixed by #337
Assignees
@moisses89
Labels
enhancement New feature or request

Comments

@moisses89
Copy link
Member

What is needed?

Add support to send transactions from Trezor.

Background

Currently we can sign transactions with Trezor, but send transactions from Trezor is not supported.

Related issues

#325
@moisses89 moisses89 added the enhancement New feature or request label Dec 15, 2023
@moisses89 moisses89 mentioned this issue Dec 15, 2023
Merged
@aspiers
Copy link

aspiers commented Dec 20, 2023

It seems that the following is needed:

  • implement get_signed_raw_transaction() in safe_cli/operators/hw_wallets/trezor_wallet.py
  • change load_hw_wallet() in safe_cli/operators/safe_operator.py so that self.hw_wallet_manager.set_sender() is called not just when hw_wallet_type == HwWalletType.LEDGER but also when hw_wallet_type == HwWalletType.TREZOR

Is there anything else?

@moisses89 moisses89 mentioned this issue Jan 4, 2024
Merged
@moisses89
Copy link
Member Author

@aspiers you are right, it was implemented here #337

@JagoFigueroa
Copy link

Looks good to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moisses89 moisses89

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support execute transaction from Trezor safe-global/safe-cli
3 participants
@aspiers @moisses89 @JagoFigueroa