Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated ledger accounts with the same address and derivation path #302

Closed
moisses89 opened this issue Nov 7, 2023 · 2 comments · Fixed by #308
Closed

Duplicated ledger accounts with the same address and derivation path #302

moisses89 opened this issue Nov 7, 2023 · 2 comments · Fixed by #308
Assignees
@moisses89
Labels
bug Something isn't working

Comments

@moisses89
Copy link
Member

Describe the bug
Two instances of LedgerAccount with the same attributes are currently evaluated as different, leading to duplication in the LedgerManager.accounts set.

In [12]: LedgerAccount("44'/60'/0'/0/10", 0x85bC4dc18e2Dde71294EA1c87CF0824A4c04489D) == LedgerAccount("44'/60'/0'/0/10", 0x85bC4dc18e2Dde71294EA1c87CF0824A4c04489D)
Out[12]: False
@moisses89 moisses89 added the bug Something isn't working label Nov 7, 2023
@moisses89 moisses89 assigned Uxio0 and moisses89 and unassigned Uxio0 Nov 7, 2023
This was referenced Nov 7, 2023
Merged
Closed
@moisses89
Copy link
Member Author

Work in progress here mikeshultz/ledger-eth-lib#51

@moisses89 moisses89 mentioned this issue Nov 16, 2023
Merged
@JagoFigueroa
Copy link

Tested and verified! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moisses89 moisses89

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix duplicated LedgerAccounts safe-global/safe-cli
3 participants
@Uxio0 @moisses89 @JagoFigueroa