Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support load_ledger_cli_owners from DERIVATION_PATH #284

Closed
moisses89 opened this issue Oct 30, 2023 · 2 comments · Fixed by #294
Closed

Support load_ledger_cli_owners from DERIVATION_PATH #284

moisses89 opened this issue Oct 30, 2023 · 2 comments · Fixed by #294
Assignees
@moisses89
Labels
enhancement New feature or request

Comments

@moisses89
Copy link
Member

What is needed?

Load_ledger_cli_owners currently return a list of addresses that ledger contains (the 5 first)
The idea is to let the users load any derivation path indicating it as parameter.

Background

#195 (comment)
@moisses89 moisses89 added the enhancement New feature or request label Oct 30, 2023
@moisses89 moisses89 mentioned this issue Nov 6, 2023
Merged
@moisses89
Copy link
Member Author

@JagoFigueroa could you check if everything is ok to this new feature?

@JagoFigueroa
Copy link

Tested and verified after the latest changes, thank you señor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moisses89 moisses89

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add derivation-path option to load ledger owners safe-global/safe-cli
2 participants
@moisses89 @JagoFigueroa