-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: expose the user (EOA) wallet provider #474
Comments
I agree this would big an huge UI UX improvement for our use case. Maybe it wouldn't be too much of a hassle to use that feature to request the safe web app to interact with the EOA wallet on behalf of the Iframe. |
Why bother with the feature then? You can generate a random private key and sign the message |
The author doesn't care but in my use-case this is essential and an huge UX improvement. |
Hi @mmv08. The purpose of the feature (back then) was to allow the Safe App to consume the wallet client (the connected wallet on the app.safe.global website). As mentioned on the description, one of the intended use cases was to be able to use the wallet client to sign a message mainly for authentication purposes within the developer's DApp. I take back this part: |
Just FYI you can use offchain signatures which should be faster: https://docs.safe.global/safe-smart-account/signatures/eip-1271 |
Hi @mmv08, We’re looking to implement a similar feature in our Safe-based DApp and are currently blocked by this. |
@ubinatus Did you find a workaround for this ?? |
@eliezerbasubi I opened this issue because I wanted to use the EOA provider to request eip712 signing. Back then I found no workaround and ended up just requiring users to on-chain sign messages. However, the Safe team later introduced the off-chain signing (with the SDK) so at Unvest we ended up using both methods for authenticating the user. Take into account that the off-chain signing method won't work for the SafeApp mobile app, just website (afaik). Will close this issue. Feel free to ask anything else. |
@ubinatus how did you authenticate users without involving other owners to approve the transaction? |
Could you please elaborate a little bit on your use case? I'm not entirely sure how it's possible to authenticate a multi-signature account without involving all the owners. |
Our use case involves authenticating an EOA within the Safe Browser by requesting a signature as soon as the user connects their wallet through the connect button of the Safe App. This will help us determine if the EOA is one of the owners of the multisig and redirect them to a specific page. We aim to implement this in a way that doesn't require approval from other owners, as it's merely for authentication entry into our dApp. While I understand that this can be achieved by the EOA provider, the Safe App does not currently expose this functionality |
Hello team. Was wondering if there is any intention on exposing the connected user EOA wallet on the
@safe-global/safe-apps-sdk
dependency so that we could interact with the EOA wallet (User, i.e. one of the owners of the multisig) and not the smart contract wallet (multisig).I believe the use case for this would be for those Safe Apps that has an an internal authentication method (e.g. SIWE) for users through message signatures (
personal_sign
) but don't want to force the user to use thesdk.txs.signMessage(message)
for obvious reasons:i) don't care if EOA is actually a valid ownerand ii) takes time to wait for all owners to approve the message and execute theGnosis Safe: Sign Message Library
and you won't like to wait that whole process just for interacting with the DApp.-> The way it can be currently handled (just for injected EOA)
Tentative feature
In other words:
"As SafeApp developer, I would like to also interact directly with the wallet provider of the connected user."
Would love your feedback on this 🥰. In case this is doable, I would be happy to create a PR for it.
The text was updated successfully, but these errors were encountered: