Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add App] DYAD Stablecoin #407

Open
8 tasks done
coffeexcoin opened this issue Oct 27, 2024 · 8 comments
Open
8 tasks done

[Add App] DYAD Stablecoin #407

coffeexcoin opened this issue Oct 27, 2024 · 8 comments
Assignees
Labels
Ready for Q.A The submission is ready for Q.A. review.

Comments

@coffeexcoin
Copy link

Entry type

  • New addition

App info

URL: https://app.dyadstable.xyz/

Manifest.json URL: https://app.dyadstable.xyz/manifest.json

Name: DYAD Stablecoin

Description: DYAD Stablecoin Protocol

Icon (PNG, 180x180): dyad-180x180 (1)

It's minified via https://tinypng.com: yes

Homepage: https://www.dyadstable.xyz/
Twitter: https://x.com/0xDYAD
GitHub: https://github.com/dyadStablecoin
Discord: https://discord.com/invite/dyad

App supports batching multiple transactions via Safe: no

Supported networks

- Mainnet

Revision checks

  • Used smart contracts were audited.
  • You have implemented the app using the Safe Apps SDK
  • Your Safe App includes a manifest.json file at the root with the required data
  • The app can be loaded as a custom Safe App in the Apps section of https://app.safe.global.
  • The app auto-connects to the Safe as a wallet
  • It doesn't try to connect to the browser wallet (e.g. MetaMask)
  • You are able to trigger and execute one transaction with a Safe.
  • RPC requests are optimized (not triggering many requests in a very short time period).

Audit document

https://github.com/DyadStablecoin/audits

Code for review

https://github.com/DyadStablecoin/frontend
https://github.com/DyadStablecoin/contracts

Team information

Company: DYAD Stablecoin

Official website: https://www.dyadstable.xyz/

Point of contact:
Joey Roth
Shafu
coffeexcoin

Telegram:
@joey_roth
@shafu0x
@coffeexcoin

@kirkkonen
Copy link

This submission was reviewed and approved by the product team.

@coffeexcoin
Copy link
Author

@kirkkonen just wanted to follow up on this - is there anything else needed here?

@tmjssz
Copy link

tmjssz commented Nov 27, 2024

I reviewed the code and it looks good to me to proceed. My suggestion for improvement:

  • Introduce basic unit test coverage

Ready to be picked up by QA.

@parius parius self-assigned this Nov 27, 2024
@github-project-automation github-project-automation bot moved this to New issues in Safe{Wallet} Nov 27, 2024
@parius parius moved this from New issues to Ready for QA in Safe{Wallet} Nov 27, 2024
@liliya-soroka
Copy link
Member

@coffeexcoin , do you have a test env, that can be used for a quick tx execution check ?

For the prod app verified:

  • app is opened
  • autoconnect to the safe
  • the tx can be triggered
  • signing and execution is not checked in the prod app

@PooyaRaki
Copy link
Contributor

@coffeexcoin We are awaiting your response to proceed with the process.

@PooyaRaki
Copy link
Contributor

@coffeexcoin I’m closing this issue for now due to inactivity. Feel free to reopen it with an update whenever you’re ready.

@github-project-automation github-project-automation bot moved this from Ready for QA to Done in Safe{Wallet} Jan 3, 2025
@coffeexcoin
Copy link
Author

Hey there @PooyaRaki - what kind of test environment are you looking for? The app is live at https://app.dyadstable.xyz

Are you looking for instructions to run it from source locally?

@PooyaRaki
Copy link
Contributor

cc @liliya-soroka

@PooyaRaki PooyaRaki reopened this Jan 6, 2025
@github-project-automation github-project-automation bot moved this from Done to Todo in Safe{Wallet} Jan 6, 2025
@liliya-soroka liliya-soroka moved this from Todo to Ready for QA in Safe{Wallet} Jan 6, 2025
@PooyaRaki PooyaRaki added the Ready for Q.A The submission is ready for Q.A. review. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Q.A The submission is ready for Q.A. review.
Projects
Status: Ready for QA
Development

No branches or pull requests

6 participants