Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Stabilization version in the tracking issue template #134990

Open
joshka opened this issue Jan 1, 2025 · 3 comments
Open

Include Stabilization version in the tracking issue template #134990

joshka opened this issue Jan 1, 2025 · 3 comments
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools needs-triage This issue may need triage. Remove it if it has been sufficiently triaged.

Comments

@joshka
Copy link
Contributor

joshka commented Jan 1, 2025

Location

  • Tracking issues
  • RFCs
  • Stabilization Issues
  • Unstable book
  • Compiler error messages

Summary

In a CI build against my crate's declared MSRV, I get this build failure:

error[E0658]: lint reasons are experimental
  --> webfinger-rs/src/types/rel.rs:6:1
   |
6  | / #[nutype(derive(
7  | |     Debug,
8  | |     Display,
9  | |     Clone,
...  |
19 | |     Eq,
20 | | ))]
   | |___^
   |
   = note: see issue #54503 <https://github.com/rust-lang/rust/issues/54503> for more information
   = note: this error originates in the attribute macro `nutype` (in Nightly builds, run with -Z macro-backtrace for more info)

The fix for this is to bump my MSRV, which I'm fine with doing. But the process for finding what version this feature was introduced in is convoluted and doesn't have any path from the error message. A good place for that information to live would the in the first comment of the tracking issue link. Adding the info to the RFC and stabilization issue would be nice too. The only place where this is recorded currently is the rust blog https://blog.rust-lang.org/2024/09/05/Rust-1.81.0.html#lint-reasons

Obviously this is just one case, but it's something I've seen happen a few times. The underlying goal of this issue is that the link to the tracking issue is not a dead end for fixing the issue, but instead contains enough information to fix immediately.

@joshka joshka added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Jan 1, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 1, 2025
@the8472
Copy link
Member

the8472 commented Jan 2, 2025

The stabilization PR has an attached milestone. Alas, in this case the tracking issue wasn't properly updated, I have rectified that now.

@joshka
Copy link
Contributor Author

joshka commented Jan 2, 2025

There are 223 PRs with stabilize in the title that have no milestone:
https://github.com/search?q=repo%3Arust-lang%2Frust+in%3Atitle+stabilize+milestone%3Anone+is%3Amerged&type=pullrequests

@the8472
Copy link
Member

the8472 commented Jan 2, 2025

The newest is from 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools needs-triage This issue may need triage. Remove it if it has been sufficiently triaged.
Projects
None yet
Development

No branches or pull requests

3 participants