Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kup ignores shell env settings, must pass env directly #108

Open
sambacha opened this issue Mar 23, 2024 · 4 comments
Open

kup ignores shell env settings, must pass env directly #108

sambacha opened this issue Mar 23, 2024 · 4 comments

Comments

@sambacha
Copy link

GitHub Rate limiting

Getting rate limited by GitHub, so passing GH_TOKEN (ref: https://github.com/runtimeverification/kup/blob/a72bf86a857e01539f161541aba76bbfb19f03cd/src/kup/__main__.py#L335C61-L335C69) into my terminal I must pass it directly to actually make an authenticated request

Failure

$ export GH_TOKEN=github_pat_(...)
$ kup install kore-rpc
warning: error: unable to download 'https://api.github.com/repos/runtimeverification/k/commits/HEAD': HTTP error 403

       response body:

       {"message":"API rate limit exceeded for 198.54.132.185. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}; using cached version
warning: error: unable to download 'https://api.github.com/repos/runtimeverification/evm-semantics/commits/HEAD': HTTP error 403

Successful

$ GH_TOKEN=github_pat_(...) kup install kore-rpc
 ⌛ Building 'kore-rpc' ...
 ✅ Successfully installed 'kore-rpc' version github:runtimeverification/haskell-backend/e50cdfc9943ad683ef7cd9917f7599f322a53b78#packages.aarch64-darwin.kore-rpc (master).
@goodlyrottenapple
Copy link
Contributor

Sorry could not reproduce this one. Could you tell me which OS/shell you are using?

@sambacha
Copy link
Author

Sorry could not reproduce this one. Could you tell me which OS/shell you are using?

Bash 5.2.26(1)-release, macOS 14.4.1 (23E224)

@F-WRunTime
Copy link
Member

@sambacha I am getting the same issue now as well. However when I run your suggested workaround. I still get the rate limit error. To be clear your command is setting the variable and immediately running the kup install command correct?

@sambacha
Copy link
Author

sambacha commented May 5, 2024

@sambacha I am getting the same issue now as well. However when I run your suggested workaround. I still get the rate limit error. To be clear your command is setting the variable and immediately running the kup install command correct?

I pass it directly in the same command line entry

GH_TOKEN=<token> <rest of commands>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants