-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROS2 port of acsi_eip_driver #7
Comments
Hey Ben man! Looks like you inherited some of my work ... good for you!
To answer your question ... I think so.
…-Bill
On Wed, Jul 24, 2019 at 3:04 PM ben-greenberg ***@***.***> wrote:
I have ported the messages and the acsi packages to ROS2. At a later point
I may get back to the stepper package, but for now wanted to share the
servo package with the community. Should there be a new ROS2 branch of this
repo that I can open a PR against?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#7>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALAW2GVIAGAH2OGL6TF6ZTQBCYWLANCNFSM4IGTYQOQ>
.
|
Hi Bill! Your original driver was well designed so the port was fairly painless, so thanks for that! Are you able to create that new ROS2 branch or should I bug someone else about it? |
Thank you for that!
If you need it done in the next week or so, better enlist someone else. I'm
leaving for a 10 day camping trip to Allegany State Park (NY) on Friday ...
too much else to do before then :)
…-Bill
On Tue, Jul 30, 2019 at 3:12 PM ben-greenberg ***@***.***> wrote:
Hi Bill! Your original driver was well designed so the port was fairly
painless, so thanks for that! Are you able to create that new ROS2 branch
or should I bug someone else about it?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#7>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALAW2G2HOBESJGGKXFSVXDQCCODNANCNFSM4IGTYQOQ>
.
|
Hi Bill, hope you're doing well! I just came upon this again and figured I should get my updates pushed out to the community. Can you make the new ROS2 branch or give me write access to do so myself? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have ported the messages and the acsi packages to ROS2. At a later point I may get back to the stepper package, but for now wanted to share the servo package with the community. Should there be a new ROS2 branch of this repo that I can open a PR against?
The text was updated successfully, but these errors were encountered: