Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change namespace? #7

Open
austinpray opened this issue Jun 9, 2019 · 1 comment
Open

Change namespace? #7

austinpray opened this issue Jun 9, 2019 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Milestone

Comments

@austinpray
Copy link
Collaborator

Sort of related to #1

namespace Roots\Bedrock;

Should this namespace be Roots\Bedrock\Autoloader ?

@austinpray austinpray added good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested labels Jun 9, 2019
@austinpray austinpray added this to the 2.0.0 milestone May 16, 2020
@aaemnnosttv
Copy link
Collaborator

This wouldn't make much difference now I don't think, but I think it's a good idea for use in the future. Now that it's a dedicated package, it might benefit from splitting up a bit into multiple classes or extract a few namespaced utility functions.

Thinking farther down, there could be sub-classes of Autoloader which might implement different strategies for autoloading, etc.

Sounds good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants