New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

differences in error handling #6

Open

killmenot opened this issue Oct 5, 2017 · 1 comment

killmenot commented Oct 5, 2017

If we take a look at no docment store logic, we can see that it uses customError function
https://github.com/robtweed/qewd/blob/master/lib/appHandler.js#L113-L119

However, if we take a look at session is not authenticated logic
https://github.com/robtweed/qewd/blob/master/lib/appHandler.js#L271-L278
we see no customError involved.

Should I add customError logic to session is not authenticated logic?

The text was updated successfully, but these errors were encountered:

Owner

robtweed commented Oct 6, 2017

Hmmm - good question. I think no, leave it as is for now. I may add custom error logic for this at a later stage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment