Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment action to format a PR #63

Open
TheTripleV opened this issue Apr 29, 2024 · 2 comments
Open

Add comment action to format a PR #63

TheTripleV opened this issue Apr 29, 2024 · 2 comments

Comments

@TheTripleV
Copy link
Member

allwpilib formats and pushes a commit to a PR if a comment with /format is made.

All the robotpy repos should get this too.

@virtuald
Copy link
Member

Seems reasonable.

@auscompgeek
Copy link
Member

Personally I'd like to switch all RobotPy repos to use pre-commit, like in robotpy/examples#122.

We wouldn't force anyone to actually install the pre-commit hook; it'd just be used to codify formatters and autofixable linters in a single file. Then we could install https://pre-commit.ci to provide autofixing on PRs.

We had to nuke allwpilib's implementation of the /format command (wpilibsuite/allwpilib#7566) due to a security incident, so if we implement autofixing in @robotpy, let's make sure we get it right the first time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants