Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming of Likelihood Methods #3

Open
rmnldwg opened this issue Sep 10, 2024 · 0 comments
Open

Naming of Likelihood Methods #3

rmnldwg opened this issue Sep 10, 2024 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed

Comments

@rmnldwg
Copy link
Owner

rmnldwg commented Sep 10, 2024

In a mixture model, there are two different likelihoods in use:

  1. The incomplete likelihood we want to maximize. This marginalizes over the latent variables and thus does not require them
  2. The complete likelihood which is much easier to compute and especially differentiate, but does require us to know/estimate the latent variables

In our model, we additionally want to compute the likelihoods of each patient under each mixture component, sometimes weighing them with the mixture coefficients and sometimes not.

So far, the result of these different likelihoods has been a mess of functions in the code. We currently have:

  1. patient_component_likelihoods()
  2. patient_mixture_likelihoods()
  3. complete_data_likelihood()
  4. incomplete_data_likelihood()

Each of them computable for slices/subsets of subgroups and components. But I think at least their names could be more informative. One could probably reduce this to two or three methods with appropriate names and a good choice of boolean flags (like use_complete or use_weighted).

@rmnldwg rmnldwg added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Sep 10, 2024
@rmnldwg rmnldwg self-assigned this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant