diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml index 80c0b0c..017f2a1 100644 --- a/.github/workflows/linter.yml +++ b/.github/workflows/linter.yml @@ -25,6 +25,7 @@ jobs: uses: github/super-linter@v7 env: VALIDATE_ALL_CODEBASE: false + VALIDATE_JSON_PRETTIER: false VALIDATE_MARKDOWN_PRETTIER: false DEFAULT_BRANCH: v5.x GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/v5-tests-and-release.yml b/.github/workflows/v5-tests-and-release.yml index 22827ad..167128b 100644 --- a/.github/workflows/v5-tests-and-release.yml +++ b/.github/workflows/v5-tests-and-release.yml @@ -236,7 +236,7 @@ jobs: short-length: 4 - name: Using correct length // Validate that all short variables lengths are equals to short-length run: | - env | grep "CSL_" | grep "_SHORT" | cut -d"=" -f2 | while read -r value; do [ "$(echo "${value}" | wc -m)" -le 5 ] ; done + env | grep "CSL_" | grep "_SHORT" | cut -d"=" -f2 | while read -r value; do [ "${#value}" -le 5 ] ; done shell: bash # Test 2 @@ -278,7 +278,7 @@ jobs: short-length: 4 - name: Using correct length // Validate that all short variables lengths are equals to short-length run: | - env | grep "CSL_" | grep "_SHORT" | cut -d"=" -f2 | while read -r value; do [ "$(echo "${value}" | wc -m)" -le 5 ] ; done + env | grep "CSL_" | grep "_SHORT" | cut -d"=" -f2 | while read -r value; do [ "${#value}" -le 5 ] ; done shell: bash # Test 2 @@ -329,7 +329,7 @@ jobs: slug-maxlength: 1 - name: Using correct max length // Validate that all slug variables lengths are equals or under the slug-maxlength run: | - env | grep "CML_" | grep "_SLUG" | cut -d"=" -f2 | while read -r value; do [ "$(echo "${value}" | wc -m)" -le 2 ] ; done + env | grep "CML_" | grep "_SLUG" | cut -d"=" -f2 | while read -r value; do [ "${#value}" -le 2 ] ; done shell: bash # Test 2 diff --git a/.jscpd.json b/.jscpd.json index 18390a6..72f0e13 100644 --- a/.jscpd.json +++ b/.jscpd.json @@ -1,3 +1,3 @@ { "threshold": 2 -} \ No newline at end of file +} diff --git a/README.md b/README.md index 1e7382e..44217db 100644 --- a/README.md +++ b/README.md @@ -37,7 +37,7 @@ This GitHub Action will expose the slug/short values of [some GitHub environment Others Slug-ish commands are available

-- `SLUG_URL` on a variable to have a `slug` variable compliant to be used in an URL +- `SLUG_URL` on a variable to have a `slug` variable compliant to be used in a URL - Like `SLUG` but `.`, and `_` are also replaced by `-` - `SHORT` on a variable will limit the string size to ~8 characters - Useful for _sha_ value @@ -87,10 +87,10 @@ Add this in your workflow - name: Inject slug/short variables uses: rlespinasse/github-slug-action@v5 with: - short-length: 7 # By default it's up to git to decide, use 8 to have the v3.x behavior + short-length: 7 # By default it's up to Git to decide, use 8 to have the v3.x behavior ``` - **Warning**: If you leave it empty, you need to checkout the source first in order to let git decide the size by itself. + **Warning**: If you leave it empty, you need to checkout the source first in order to let Git decide the size by itself.

@@ -102,7 +102,7 @@ Check for more [examples][examples] (OS usage, URL use, ...) The short sha length is not the same as previous version. -- Since `v4` let git configuration decide of it (but you can override it), +- Since `v4` let Git configuration decide of it (but you can override it), - With `v3` and before, it's always a length of 8 characters. So to reproduce previous behavior, use @@ -172,7 +172,7 @@ So to reproduce previous behavior, use ### The SHORT variables doesn't have the same lengths as before -Since `v4`, it's git who manage the short variables by using [git rev-parse][git-revparse] behaviour. +Since `v4`, it's Git who manage the short variables by using [git rev-parse][git-revparse] behaviour. The length of a short sha depends of the size of our repository and can differ over time. To manage that moving length, you can use `short-length` input @@ -243,16 +243,16 @@ In English :gb: - [Action spotlight by Michael Heap][article-2] - [Serverless Deploy Previews on GitHub Actions][article-3] -- [Let's Build a Continuous Delivery and Branching Process with Github Actions, Vercel and Heroku][article-4] +- [Let's Build a Continuous Delivery and Branching Process with GitHub Actions, Vercel and Heroku][article-4] In French :fr: - [Mettre en place une CI/CD Angular avec GitHub Actions & Netlify][article-1] -- [Github Actions : enfin des pipelines accessibles aux développeurs][talk-1] +- [GitHub Actions : enfin des pipelines accessibles aux développeurs][talk-1] In Chinese :cn: -- [利用github-slug-action暴漏Github Action上下文中的关键变量][article-5] +- [利用github-slug-action暴漏GitHub Action上下文中的关键变量][article-5] > The next one is you. _Don't hesitate to add youself to one of these lists._