Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #18 breaks requests with joins #19

Open
maozedong opened this issue Jul 7, 2022 · 2 comments
Open

PR #18 breaks requests with joins #19

maozedong opened this issue Jul 7, 2022 · 2 comments

Comments

@maozedong
Copy link

First of all thanks for this fork! It fixes a number of crucial issues

#18 fixes some mysql issues, but introduces an issue for requests with manyToOne and manyToMany joins. Because of that we need to stick with 5.1.1 version

Can it be reverted? Or maybe some conditional logic can be added to decide wether skip or offset should be used?

cc: @Darkein

@rewiko
Copy link
Owner

rewiko commented Jul 17, 2022

reverted in 5.1.9

@Darkein
Copy link

Darkein commented Aug 10, 2022

so sad, it's my turn to be stuck with 5.1.8 :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants