Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove **BuildRequires/Requires: python-pep8** from spec file #13

Open
4 of 7 tasks
chkumar246 opened this issue Jul 25, 2017 · 1 comment
Open
4 of 7 tasks

Remove **BuildRequires/Requires: python-pep8** from spec file #13

chkumar246 opened this issue Jul 25, 2017 · 1 comment

Comments

@chkumar246
Copy link
Contributor

chkumar246 commented Jul 25, 2017

python-pep8 package is used to check the sanity and syntex of python code.
During rpm building process, we donot perform syntex checking of the code as it
is handled by project ci itself or by using tox.ini.
In RDO Packages, at most places python-pep8 is used as BuildRequires or Requires.

What to improve:

  1. Clone keystoneauth1-distgit spec file by doing git clone https://github.com/rdo-packages/keystoneauth1-distgit
  2. Go to keystoneauth1-distgit and open python-keystoneauth1.spec in editor.
  3. You can find Requires: python-pep8 OR/AND BuildRequires: python-pep8 in spec file.
  4. We need to remove those lines from spec file.
  5. Once done! Make changes, add and commit it and send a Gerrit Review.
  6. Please cross checklist
    before sending Gerrit Review.

Example Spec containing the above fix:

  1. python-oslo-service

Below is the list of packages which need same fixes:

Mentors

  1. chandankumar
@snecklifter
Copy link
Contributor

@chkumar246 I think senlin unit tests require python-pep8?

See comment against patch 29

https://review.rdoproject.org/r/#/c/7470/

rdoproject pushed a commit to rdo-packages/sahara-distgit that referenced this issue Aug 2, 2017
Fixed for issue redhat-openstack/easyfix#13

Change-Id: I6bb6342e306162f418869a2ce256aa61ef15f5a0
rdoproject pushed a commit to rdo-packages/glance-distgit that referenced this issue Aug 5, 2017
Fixed for issue redhat-openstack/easyfix#13

Change-Id: I06a963e9035a7a22d654a77ef3eea6c64d5783a1
rdoproject pushed a commit to rdo-packages/cinder-distgit that referenced this issue Aug 5, 2017
Fixed for issue redhat-openstack/easyfix#13

Change-Id: I92df20a484ee41510e435e301e140ca7daad7c18
rdoproject pushed a commit to rdo-packages/nova-distgit that referenced this issue Aug 5, 2017
Fixed for issue redhat-openstack/easyfix#13

Change-Id: Ice1ae7dbc459a6c64d15f378416c3d55f3d569e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants