Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve commit messages #2

Open
rafguns opened this issue Sep 14, 2022 · 2 comments
Open

Improve commit messages #2

rafguns opened this issue Sep 14, 2022 · 2 comments

Comments

@rafguns
Copy link
Owner

rafguns commented Sep 14, 2022

Because so many journal records change (mainly because of added articles) and csv-diff lists each of them, it seems like commit messages can become close to 500KB, which seems excessive.

@rafguns
Copy link
Owner Author

rafguns commented Sep 14, 2022

The proper way to fix this is probably within csv-diff itself, e.g. by adding an option to generate shorter commit messages and/or ignore certain columns. For now, I am thinking of applying a hacky workaround and just using the title.

rafguns added a commit that referenced this issue Sep 14, 2022
This is a temporary hack to work around issue #2.
rafguns added a commit that referenced this issue Sep 14, 2022
This is a temporary hack to work around issue #2.
@rafguns
Copy link
Owner Author

rafguns commented Sep 14, 2022

Hacky workaround is in place now. This works but I still think it would be nice if we could ignore certain columns, like Number of Article records and Most recent Article Added. That alone would both trim down the size of the diff and the full commit message.

@rafguns rafguns changed the title Commit messages are huge Improve commit messages Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant