Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related functionality of SSHSIG signature verification #12138

Closed
castedo opened this issue Dec 13, 2024 · 2 comments
Closed

Related functionality of SSHSIG signature verification #12138

castedo opened this issue Dec 13, 2024 · 2 comments

Comments

@castedo
Copy link

castedo commented Dec 13, 2024

This is a discussion item regarding possible new documentation or addition of the following functionality.

I have a preliminary packaging of Python code that performs SSHSIG [1] signature verification at:

https://gitlab.com/perm.pub/sshsiglib

It is currently "vendored" (loosely speaking) into the hidos Python package (https://pypi.org/project/hidos/). I use it to perform SSH key signature verification on git commits with the dulwich Python package (https://pypi.org/project/dulwich/). Long-term, I do not think it makes sense for this code to stay buried inside the specialized application of hidos.

My current inclination is to deploy this SSHSIG signature verification code as a tiny independent Python package called sshsig. But it occurred to me that maybe it should eventually live inside the cryptography package? Any thoughts?

Regardless, in the medium-term, it probably makes sense for this SSHSIG verification code to exist as a tiny independent Python package. I've already done most of the work to do so.

I had originally thought of embedding it inDulwich [2] but now that I've seen the details of doing that, I'm now more inclined to make it a separate Python package on PyPI.

This is code heavily adapted from code originally written by @grawity. Thank you!

[1] https://github.com/openssh/openssh-portable/blob/master/PROTOCOL.sshsig
[2] jelmer/dulwich#1391

@alex
Copy link
Member

alex commented Dec 13, 2024

I don't have strong feels about whether it makes sense for SSHSIG to live in cryptography or not.

If someone wants to propose some specific APIs for cryptography, that's something we could consider.

@castedo
Copy link
Author

castedo commented Jan 5, 2025

I have now packaged and released a very small Python package sshsig. The source code is also available at https://github.com/castedo/sshsig/. Documentation is currently at https://castedo.github.io/sshsig/.

I'll go ahead and close this issue since I don't think anyone has plans to add this functionality into the cryptography package.

@castedo castedo closed this as completed Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants