allow gas-custom-errors rule to properly handle custom errors inside require statements

[shaspitz]

Solidity 0.8.26 introduces the ability to use custom errors within require statements. When using this functionality (custom error in conjunction w/ require statement), solhint faultily marks the line as having a gas-custom-errors infraction

[CJ42]

Agree as these warnings are now misleading. A release with this support would be welcome.

[CJ42]

Any updates on this? It would be useful to have, as custom error in require(...) statements is likely to be used more often with solc 0.8.27

[dbale-altoros]

I will address several issues in the upcoming weeks and get a new release before new year
sorry the delay guys

[dbale-altoros]

refer to this pr
#613
I think this fix the issue
Take a look at the first 5 tests on
test/rules/gas-consumption/gas-custom-errors.js
All start with should NOT raise error for require

If you find any other case , please advice

[shaspitz]

Thanks! Is there a release I can reference with this fix?

[dbale-altoros]

not yet but soon enough will be before 2025

…

On Fri, Dec 20, 2024 at 5:56 PM Shawn ***@***.***> wrote: Thanks! Is there a release I can reference with this fix? — Reply to this email directly, view it on GitHub <#602 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVOBPIECIDKXRFQL6X5DSNL2GSAA7AVCNFSM6AAAAABOEILR7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJXG4YDKNZYGI> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

-- Diego Bale Tech Lead - Senior Solidity Dev | protofire.io <http://t.me/eldanba>: @eldanba ✉️: ***@***.*** [image: linkedin icon] <https://www.linkedin.com/in/diegobale/> The content of this email is confidential and intended for the recipient specified in the message only. It is strictly forbidden to share any part of this message with any third party, without the written consent of the sender. If you received this message by mistake, please reply and follow with its deletion, so we can ensure such a mistake does not occur.