Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any better way to show welcome modal ? #22

Open
princekhunt opened this issue Jun 14, 2024 · 3 comments
Open

Is there any better way to show welcome modal ? #22

princekhunt opened this issue Jun 14, 2024 · 3 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@princekhunt
Copy link
Owner

Is your feature request related to a problem? Please describe.
We're showing modal on login that, this is your username, and share it with the friend. Is there any better way to show this message ?

Describe the solution you'd like
maybe styles improvements.

welcome message
@princekhunt princekhunt added help wanted Extra attention is needed question Further information is requested labels Jun 14, 2024
@sudarshankakde
Copy link
Contributor

we can add an option to share private chatroom links with friends which can be easily done by using some parameters in the URL. which can letter on be check using js in frontend for connection

@princekhunt
Copy link
Owner Author

We already have URL to add friend directly, currently we call this URL by the connect user form only.

However, anyone can directly add friend by calling this endpoint.

For example user-A propagates a link to everyone.
Now user-B call this endpoint(link)

https://privateping.bytespot.tech/addfriend/user-A?note=

then, a friend request will be sent to user-A from user-B's account.

@sudarshankakde
Copy link
Contributor

we haven't allowed sharing the link with friends or showing the direct link in the model anywhere. and we should use Swalfire for the model showing the username and link at the opening. it will maintain model consistancy all over the website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants