Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TryDrawCard to API #14

Open
primitiveType opened this issue Aug 22, 2021 · 1 comment
Open

Add TryDrawCard to API #14

primitiveType opened this issue Aug 22, 2021 · 1 comment
Assignees
Labels

Comments

@primitiveType
Copy link
Owner

primitiveType commented Aug 22, 2021

It will need to support arguments containing information about the attempted draw.

  • Is the draw triggered by an entity?
  • Is the draw a start-of-turn draw?
  • Is there anything else we need to include here? Are there other cases an effect might care about?

Branch should include BattleTrance implementation to test it with.

@primitiveType primitiveType self-assigned this Aug 22, 2021
This was referenced Aug 22, 2021
Merged
@snapperVibes
Copy link
Collaborator

snapperVibes commented Aug 22, 2021

My hope is for all the "try" methods to have the same API, but TryDrawCard is messing it up.

Let's contrast TryDrawCard with TryDealDamage. If you TryDealDamage(5), it would deal 5 damage 1 time. If you would TryDrawCard(5), it would draw 1 card 5 times.

Edit: discussed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants