Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Green deployment #153

Open
ArseniiPetrovich opened this issue Jul 5, 2018 · 1 comment
Open

Green deployment #153

ArseniiPetrovich opened this issue Jul 5, 2018 · 1 comment

Comments

@ArseniiPetrovich
Copy link
Collaborator

ArseniiPetrovich commented Jul 5, 2018

As "Ansible" best practice says each play that does not change anything should result with "ok" status. However, even when we launch a deployment with the same configs we get something like

PLAY RECAP ***************************************************************
40.121.145.132             : ok=69   changed=5    unreachable=0    failed=0  

The root of this issue lies in the fact that some of the tasks, that does not actually change anything results with "changed" code. So, instead of totally "green" deployment we get "yellow-green", which leads to incorrect interpretation of deployment and may cause issues like #147.
What I propose is to refactor all the tasks to return "green" code when state remains unchanged.

@phahulin
Copy link
Contributor

phahulin commented Jul 5, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants