Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

Replace Yarn PnP w/ Yarn 2 #31

Open
arcanis opened this issue Jan 5, 2020 · 5 comments · May be fixed by #41
Open

Replace Yarn PnP w/ Yarn 2 #31

arcanis opened this issue Jan 5, 2020 · 5 comments · May be fixed by #41

Comments

@arcanis
Copy link
Collaborator

arcanis commented Jan 5, 2020

Since Yarn 2 has PnP enabled (with a better implementation as Yarn 1), I think it would make more sense to use that.

To use Yarn 2, the following command has to be run within the project outside of the benchmark:

yarn policies set-version berry

Some other particularities:

  • to remove the cache, better use yarn cache clean --all. You also can add enableGlobalCache which will use a unique cache (otherwise it'll have a first global cache, then a per-project cache).

  • when removing the n_m, you'll instead want to remove the .pnp.js file for PnP (I think it's currently marked as n/a)

@zkochan
Copy link
Member

zkochan commented Jan 5, 2020

I don't have objections

@omeid
Copy link

omeid commented Jan 31, 2020

I would prefer if it was added along with yarn PnP than replaced, it should give a better picture of the overall packaging landscape.

@arcanis
Copy link
Collaborator Author

arcanis commented Jan 31, 2020

Not really, the 1.x PnP implem was an experiment branch we never bumped to production. The amount of people who care about that is small.

@omeid
Copy link

omeid commented Feb 2, 2020

Can you explain what do you mean by bumped to production?

@arcanis arcanis linked a pull request Feb 11, 2020 that will close this issue
@doamatto
Copy link

Bumping and +1. Would be great to know if it's worth switching from Yarn 2 from a benchmarking POV

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants