Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golf: JsonMaskObjectNIVC #25

Closed
Autoparallel opened this issue Nov 2, 2024 · 4 comments
Closed

golf: JsonMaskObjectNIVC #25

Autoparallel opened this issue Nov 2, 2024 · 4 comments
Labels
feature ✨ New feature or core functionality performance ⚡️ This will not be worked on

Comments

@Autoparallel
Copy link
Contributor

Currently the specific:

JsonMaskObjectNIVC(1024, 10, 10)

is: non-linear constraints: 365224.

We need to reduce this. I'm sure we can simplify this circuit!
@Autoparallel
Copy link
Contributor Author

@lonerapier wanna take a look?

@lonerapier
Copy link
Collaborator

Looking into this, and most of it is due to not-so efficient substring search algorithm.

Large r1cs file of LockHeader template and high constraint count of JsonMaskObjectNIVC template depends upon string search for header/key.

  • LockHeader -> FirstStringMatch
  • JsonMaskObjectNIVC -> KeyMatchAtDepth

@0xJepsen 0xJepsen added performance ⚡️ This will not be worked on feature ✨ New feature or core functionality labels Nov 8, 2024
@Autoparallel
Copy link
Contributor Author

I'm going to tackle this a different way with #41

@Autoparallel
Copy link
Contributor Author

Closing this as we don't need to do this directly anymore.

@Autoparallel Autoparallel closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature ✨ New feature or core functionality performance ⚡️ This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Autoparallel @lonerapier @0xJepsen