Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in documentation for extended attributes #29

Open
tabatkins opened this issue Sep 25, 2017 · 0 comments
Open

Bug in documentation for extended attributes #29

tabatkins opened this issue Sep 25, 2017 · 0 comments

Comments

@tabatkins
Copy link
Contributor

From the README:

A list of extended attributes, or None. Extended attributes are stored as Constructs, those of the forms: 'identifier', 'identifier=identifier', 'identifier(ArgumentList)', 'identifier=identifier(ArgumentList)', or 'identifier(Type,Type)' are parsed. The first identifier is stored in 'Construct.attribute', the second, if present, is stored in 'Construct.name', arguments are stored in 'Construct.arguments'. Extended attributes not mathing those five forms contain a list of tokens in 'Construct.tokens' and their name is set to 'None'.

I interpreted this as saying that, if encountering [Exposed=Window], the string "Exposed" would be in .attribute, while "Window" would be in .name. I'm not sure how else to read it, actually.

This is wrong, tho - .name contains "Exposed", .attribute appears to contain the attribute itself again, and I don't know where "Window" is stored at all. (Maybe .arguments? I haven't checked yet.)

(I'm trying to resolve #27 and speced/bikeshed#1077 right now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant