-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload file - Cancelling upload file results in error and does not prevent the uploaded file #10705
Comments
@Tribunal33, is this the same as #10660? |
I think that has a similar root problem but not exactly the same. The problem is that it adds a file that is cancelled rather than removing an existing file. |
Ready for review @asmecher Submodule updates ojs (main): pkp/ojs#4607 |
All merged and updated, thanks, @taslangraham! @Tribunal33, here's another one to test -- preferrably on |
Describe the bug
Seems to be an issue with upload module on 3.4 and 3.5 versions. There are two issues. First, is after selecting a file to upload the cancel button no longer prevents the uploaded of the file to show up on the submission list. Second, the cancel button doesn't immediately close the workflow and when the user selects continue it shows that there is a file not found error in the console.
Potentially connected to #10660 but not the revision scenario.
Preconditions :
Default dataset
To Reproduce
Steps to reproduce the behavior:
Actual : The first issue results in the file being added to the list even though the user tries to cancel the upload. The second issue shows an error in the console.
Expected: The file should not be uploaded if the user selects Cancel at any point in the workflow and no error in console when selecting continue.
What application are you using?
OJS, OMP or OPS version 3.4.0 and 3.5.0
Additional information
Please add any screenshots, logs or other information we can use to investigate this bug report.
The text was updated successfully, but these errors were encountered: