Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze when coordinates are NaN #7

Open
Viza74 opened this issue Jun 23, 2017 · 2 comments
Open

Freeze when coordinates are NaN #7

Viza74 opened this issue Jun 23, 2017 · 2 comments

Comments

@Viza74
Copy link

Viza74 commented Jun 23, 2017

I accidentally passed NaN's as coordinates for circfill, and the whole game/page freezed totally, so I had to close the page and reopen again (Granted, i'm not a web developer, so probably there is a nicer way to solve this...)

sprcp with the same NaN coordinates just not draws anything, but at least not freezes.

I only tried with circfill, I don't know what happens with the other drawing routines.

@pistacchio
Copy link
Owner

I'll handle values that are not numbers and ignore them.
Thanks again, you're submitting some very useful reports.

@pistacchio pistacchio added the bug label Jun 23, 2017
@pistacchio pistacchio modified the milestone: 0.1.4 Jun 24, 2017
@pistacchio
Copy link
Owner

I gave it a try at fully sanitizing the input but, where you stress the engine a bit, it is too computationally expensive. Expecially checking for NaN is extremely time consuming, so I'll leave the issue open as enhancement till I figure out how to sanitize all the inputs without taxing the CPU too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants